Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX release] Avoid unnecessary change events during initial render #11935

Merged
merged 3 commits into from
Jul 31, 2015
Merged

[BUGFIX release] Avoid unnecessary change events during initial render #11935

merged 3 commits into from
Jul 31, 2015

Commits on Jul 31, 2015

  1. [BUGFIX release] Avoid positionalParams changing attrs after create.

    @rwjblue
    rwjblue committed Jul 31, 2015
    Configuration menu
    Copy the full SHA
    fbe3f03 View commit details
    Browse the repository at this point in the history

  2. [BUGFIX release] Setup named positionalParam array. 

    Previously, when `positionalParams` was a string value (which means to
set all params as an array at that particular prop in `attrs`) we were
iterating over the length of the destination property name instead of
the available `params`.
    @rwjblue
    rwjblue committed Jul 31, 2015
    Configuration menu
    Copy the full SHA
    4373ac6 View commit details
    Browse the repository at this point in the history

  3. [BUGFIX release] Avoid double-setting attrs during initial renders 

    This significantly reduces unnecessary event firing during the initial
render of each component. In my sample scenario, it cut average events
per component from 14.9 to 7.07.

This does not have a major performance impact by itself, but
applications that are observing any of these events may experience
improvement.
    @ef4
    ef4 committed Jul 31, 2015
    Configuration menu
    Copy the full SHA
    b0f6540 View commit details
    Browse the repository at this point in the history