[BUGFIX release] Avoid unnecessary change events during initial render #11935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when `positionalParams` was a string value (which means to set all params as an array at that particular prop in `attrs`) we were iterating over the length of the destination property name instead of the available `params`.
This significantly reduces unnecessary event firing during the initial render of each component. In my sample scenario, it cut average events per component from 14.9 to 7.07. This does not have a major performance impact by itself, but applications that are observing any of these events may experience improvement.
ef4
changed the title
|
Im seeing 10% - 15% improved render times, and this looks good to me. I have found some more work amplfications. Will report shortly. |
|
There is no semantic change here, 'this.attrs' was already available at component 'init', the main difference is that we avoid 'set(component, "attrs", attrsSnapshot)' (after having just set/passed those attrs when creating the component anyways). I'm very 👍 |
stefanpenner
added a commit
that referenced
this pull request
Jul 31, 2015
[BUGFIX release] Avoid unnecessary change events during initial render
|
@ef4 Awesome Edward! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reduces unnecessary event firing during the initial render of each component. In my sample scenario, it cut average events per component from 14.9 to 7.07.
(The seven remaining events are the ones that are supposed to fire once each: didInitAttrs, didInsertElement, didReceiveAttrs, didRender, init, willInsertElement, and willRender.)
The impact on actual render time is not necessarily large (a few scenarios I looked at improved by up to 10%), but applications that are doing more expensive work in their observers may see bigger benefits.
This change is based on @stefanpenner's investigation in this comment. It's built on top of @rwjblue's PR #11934, since it would otherwise conflict and is attacking a related problem.
My changes are relatively small, you can see them in isolation here.