[BUGFIX beta] Properly detect if the environment is Node. #11895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check for both `process` and `window` when determining if the environment is Node. * Closes emberjs#11679.
This was referenced Jul 25, 2015
|
Looks good to me. @stefanpenner - Can you also review? |
|
what about webworkers in those environments, do they also have global process? |
|
@edeblois - Can you double check? |
|
@stefanpenner Node is not available to web workers, both in NW.js and Electron. In those cases, you neither have |
stefanpenner
added a commit
that referenced
this pull request
Jul 26, 2015
[BUGFIX beta] Properly detect if the environment is Node.
|
Thanks @brzpegasus! |
awesome, this was the piece if information I was unclear about. Thanks for sharing. |
|
This is still broken in |
|
@bastimeyer - Yep, that is what it was targeted for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes how we currently determine if the running environment is Node, by also ensuring that
windowis not defined. Simply checking forprocessis insufficient in browser environments such as those provided by NW.js or Electron, which also define awindow.process.I'll make a separate PR to rsvp to get it fixed there as well.
Closes #11679
Update: Relates to tildeio/rsvp.js#398