Fix NW configuration for Ember 1.13.x #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember 1.13.x checks for the existence of `process` to determine if it is running in Node (probably for Fastboot). This can result in errors trying to load an Ember app in NW.js. Changes: * The shim script will now delete `window.process` then restore it at the end. * Restoring NW.js variables on the window `load` event would not guarantee to run when it should. The shim is now split between 2 scripts: `shim-head.js` and `shim-footer.js`, both of which are injected into the page via the `contentFor` hooks. * The `vendor/node-webkit/*.js` blueprint files are no longer necessary and have been removed. * The `reload.js` file was moved from the blueprint to the addon's `client/node-webkit/` folder and will be managed entirely by the addon itself. The consuming app won't have a copy of it laying around. * The addon now sets a `process.env.EMBER_CLI_NW = true` for all of its commands. This ensures that custom build steps only execute for the correct environment.
brzpegasus
added a commit
that referenced
this pull request
Jul 24, 2015
Fix NW configuration for Ember 1.13.x
|
I'd kinda like to fix this in Ember itself also. I believe there is an open issue in the Ember repo for it (can't recall from whom though). |
|
Sounds great, would you mind testing that out locally and submitting a pull request to Ember? |
|
👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember 1.13.x checks for the existence of
processto determine if it is running in Node (probably for Fastboot). This can result in errors trying to load an Ember app in NW.js.Changes:
window.processthen restore it at the end.loadevent would not guarantee to run when it should. The shim is now split between 2 scripts:shim-head.jsandshim-footer.js, both of which are injected into the page via thecontentForhooks.vendor/node-webkit/*.jsblueprint files are no longer necessary and have been removed.reload.jsfile was moved from the blueprint to the addon'sclient/node-webkit/folder and will be managed entirely by the addon itself. The consuming app won't have a copy of it laying around.process.env.EMBER_CLI_NW = truefor all of its commands. This ensures that custom build steps only execute for the correct environment.