[BUGFIX release] Rerender link on routing state change.

[juggy]

Properly update the route when the routing current state change. This primarily deals with query-params only routes as noted in issue #11533 .

[stefanpenner]

can you add a failing test? I want to be sure i understand the actual issue (in code-form) this aims to work around.

[juggy]

Where are the tests for the link component? Can't seem to find them.

[stefanpenner]

I don't know off the top of my head, but maybe they dont exist in isolation.

[mixonic]

0_o there are integration tests here:

• https://github.com/emberjs/ember.js/blob/master/packages/ember/tests/helpers/link_to_test.js

and some more unitish tests here:

• https://github.com/emberjs/ember.js/blob/master/packages/ember-routing-htmlbars/tests/helpers/link-to_test.js

[juggy]

Thanks @mixonic. Here you go for the test. Failing on master but passing here.

[rwjblue]

Can you explain why the href computed dep key was not enough to update the href when the route changes? I am sure there is more internal detail that you tracked down when making this patch, so I'm hoping you can walk me through the 'why'...

[juggy]

There is a special case for query-params only link-tos as you can see here https://github.com/juggy/ember.js/blob/query-params-links/packages/ember-routing-views/lib/views/link.js#L452-L463

As you can see, the targetRouteName changes every time the route changes. The problem here is that the willRender is not called, because this change happens even if the attrs of the LinkComponent do not change (which would trigger a rerender).

Another solution to the problem would be to move this special case to the href computed property. That would remove the observer.

[juggy]

Removed the observer, moved the onlyQueryParamsSupplied logic to the href.

[stefanpenner]

this appears much more reasonable :) Still needs someone else to review.

[rwjblue]

Looks good to me, can you prefix with [BUGFIX release]?