Query-params only Link-Tos do not update anymore when route/url change

[juggy]

Please consider http://output.jsbin.com/vexeho#/no-model

You will see that if you change the route from "no-model" to "model" the 2 query-params route will not refresh to show the new route (it will still have a href with /no-model?a=).

In the previous version of Ember, it would update based on the current page/url.

[jmurphyau]

Can you provide a JSBin with an older version where you demonstrate this working?

I can see the 'a' query param is set on the ApplicationController - which is always active.. Seems like normal behaviour having a=[something] for each route.

[juggy]

Here a version with 1.10 http://output.jsbin.com/dixigo

You will see that the first link (params 1) href will update when you move from route to route (by clicking the bottom 2 links).

This is not the case with the version using ember 1.13: http://output.jsbin.com/vexeho

[juggy]

Update bins:
canary: http://jsbin.com/vexeho/9/edit?html,js,output
with PR #11535 : http://jsbin.com/jutako/4/edit?html,js,output

You should compare against working 1.10 version:
1.10: http://jsbin.com/dixigo/3/edit?html,js,output

Thanks

[juggy]

@jmurphyau are you familiar with the code behind this? I would try to fix this, but I do not know where to start...

[jmurphyau]

The targetRouteName of the LinkComponent isn't getting updated when _routing.currentState changes..

In 1.10, there is logic between:

if (onlyQueryParamsSupplied) {
...
else
...
}

That runs every time the URL changes - in 1.13 this gets run on willRender which is only run once...

I'm wondering if willRender is meant to be triggered, or if the solution is to call this.rerender()? Or is the solution just to fix targetRouteName not being tracked correctly on route changes? It feels to me like the component should be rerendered and willRender called (which looks like it would solve this problem)

[rwjblue]

Fixed by #11561.