Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Don't dispatch new lifecycle hooks to views #11229

Merged
merged 1 commit into from
May 25, 2015

Commits on May 20, 2015

  1. Don't dispatch new lifecycle hooks to views

    Since 84c2875, the lifecycle hooks are inconsistent between views and
    components. For example, the `willReceiveAttrs` hook has been renamed to
    `didReceiveAttrs` on components but not on views. Talked to @wycats about it,
    the plan is "to remove all of the new lifecycle hooks from views", because
    "views are sufficiently crazy that I don't want to try to mix in new semantics".
    
    In this commit:
    
    - [x] ✂️ `didUpdate` from `View`s
    - [x] ✂️ `willReceiveAttrs` from `View`s
    - [x] Rename `willRender` to `_willRender` on `View`s (for now)
    - [x] Rename `willUpdate` to `_willUpdate` on `View`s (for now)
    
    TODO:
    
    - [ ] Refactor internal `View`s to not use `_willRender`
    - [ ] Refactor internal `View`s to not use `_willUpdate`
    - [ ] ✂️ `_willRender` from `View`s
    - [ ] ✂️ `_willUpdate` from `View`s
    chancancode committed May 20, 2015
    Configuration menu
    Copy the full SHA
    baa4573 View commit details
    Browse the repository at this point in the history