[BUGFIX beta] Don't dispatch new lifecycle hooks to views #11229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 84c2875, the lifecycle hooks are inconsistent between views and components. For example, the `willReceiveAttrs` hook has been renamed to `didReceiveAttrs` on components but not on views. Talked to @wycats about it, the plan is "to remove all of the new lifecycle hooks from views", because "views are sufficiently crazy that I don't want to try to mix in new semantics". In this commit: - [x] ✂️ `didUpdate` from `View`s - [x] ✂️ `willReceiveAttrs` from `View`s - [x] Rename `willRender` to `_willRender` on `View`s (for now) - [x] Rename `willUpdate` to `_willUpdate` on `View`s (for now) TODO: - [ ] Refactor internal `View`s to not use `_willRender` - [ ] Refactor internal `View`s to not use `_willUpdate` - [ ] ✂️ `_willRender` from `View`s - [ ] ✂️ `_willUpdate` from `View`s
chancancode
changed the title
|
I can confirm that this is on the right track 😄 |
|
Looks good. Will merge this, and then when you have time you can finish the additional TODO items. |
rwjblue
added a commit
that referenced
this pull request
May 25, 2015
[BUGFIX beta] Don't dispatch new lifecycle hooks to views
|
|
|
LOL, 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for #11143
Since 84c2875, the lifecycle hooks are inconsistent between views and
components. For example, the
willReceiveAttrshook has been renamed todidReceiveAttrson components but not on views. Talked to @wycats about it,the plan is "to remove all of the new lifecycle hooks from views", because
"views are sufficiently crazy that I don't want to try to mix in new semantics".
In this commit:
didUpdatefromViewswillReceiveAttrsfromViewswillRenderto_willRenderonViews (for now)willUpdateto_willUpdateonViews (for now)TODO:
Views to not use_willRenderViews to not use_willUpdate_willRenderfromViews_willUpdatefromViews@wycats can you c/d if this is on the right track?