-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Glimmer Engine #10501
Implement Glimmer Engine #10501
Commits on Apr 2, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 22c7c6a - Browse repository at this point
Copy the full SHA 22c7c6aView commit details -
Attrs, scope and view destruction cleanup
This commit fixes several edge cases in how scope was managed in templates, how attrs are looked up, and how views are cleaned up, particularly the willDestroyElement user hook.
Configuration menu - View commit details
-
Copy full SHA for b504a00 - Browse repository at this point
Copy the full SHA b504a00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 907910f - Browse repository at this point
Copy the full SHA 907910fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d65c7cb - Browse repository at this point
Copy the full SHA d65c7cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for f39428f - Browse repository at this point
Copy the full SHA f39428fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9bb21a - Browse repository at this point
Copy the full SHA f9bb21aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef9d51e - Browse repository at this point
Copy the full SHA ef9d51eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d2e775 - Browse repository at this point
Copy the full SHA 4d2e775View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7ab85c - Browse repository at this point
Copy the full SHA c7ab85cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e61a6a - Browse repository at this point
Copy the full SHA 3e61a6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0346b9b - Browse repository at this point
Copy the full SHA 0346b9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72bbc6f - Browse repository at this point
Copy the full SHA 72bbc6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ba35a6 - Browse repository at this point
Copy the full SHA 9ba35a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f23f4cd - Browse repository at this point
Copy the full SHA f23f4cdView commit details -
No longer requires `npm link` for HTMLBars.
Configuration menu - View commit details
-
Copy full SHA for f6640d7 - Browse repository at this point
Copy the full SHA f6640d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dd0093 - Browse repository at this point
Copy the full SHA 2dd0093View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1bff06 - Browse repository at this point
Copy the full SHA a1bff06View commit details -
Configuration menu - View commit details
-
Copy full SHA for df2e6a9 - Browse repository at this point
Copy the full SHA df2e6a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d171bb - Browse repository at this point
Copy the full SHA 6d171bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 992f4af - Browse repository at this point
Copy the full SHA 992f4afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19cd545 - Browse repository at this point
Copy the full SHA 19cd545View commit details
Commits on Apr 3, 2015
-
Configuration menu - View commit details
-
Copy full SHA for bfa40e2 - Browse repository at this point
Copy the full SHA bfa40e2View commit details
Commits on Apr 6, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 34e28a2 - Browse repository at this point
Copy the full SHA 34e28a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cc0894 - Browse repository at this point
Copy the full SHA 7cc0894View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3b9668 - Browse repository at this point
Copy the full SHA a3b9668View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1fb347 - Browse repository at this point
Copy the full SHA e1fb347View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8da40d9 - Browse repository at this point
Copy the full SHA 8da40d9View commit details -
Allow Handlebars compat helpers to specify additional dep keys.
In Ember.Handlebars helpers it is possible to add additional dependent keys: ```javascript Ember.Handlebars.helper('capitalize-name', function(value) { return get(value, 'name').toUpperCase(); }, 'name'); ``` --- Unfortunately, the area that we know about the render node and can add more dependent keys, had no knowledge of the individual helper being rendered. Thsi commit adds a `findHelper` call to `linkRenderNode` so that we can determine if additional dependent keys are needed. This is sub-optimal because the additional `findHelper` may have a negative impact on render speed, but a better solution is not currently possible.
Configuration menu - View commit details
-
Copy full SHA for edcb457 - Browse repository at this point
Copy the full SHA edcb457View commit details -
Process
fooBinding
in general.Previously, the `TransformOldBindingSyntax` AST walker was only processing `{{view}}` invocations. This change makes it process all helper invocation, and updates a number of related tests. In order to do that, we had to change the asserts and deprecations in the transform so that when the `loc` information is not present no errors are thrown.
Configuration menu - View commit details
-
Copy full SHA for 878f2cf - Browse repository at this point
Copy the full SHA 878f2cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e19bfa - Browse repository at this point
Copy the full SHA 5e19bfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e338d0 - Browse repository at this point
Copy the full SHA 7e338d0View commit details -
Update to use new _itemViewTemplate for CollectionView test.
The `{{collection}}` helper sets this automatically, so we need to ensure the tests follow suit.
Configuration menu - View commit details
-
Copy full SHA for 6401464 - Browse repository at this point
Copy the full SHA 6401464View commit details -
Configuration menu - View commit details
-
Copy full SHA for b120eb1 - Browse repository at this point
Copy the full SHA b120eb1View commit details
Commits on Apr 7, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 29e6eae - Browse repository at this point
Copy the full SHA 29e6eaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for c868b10 - Browse repository at this point
Copy the full SHA c868b10View commit details -
Some are still skipped, but will require further thought/details on passing the renderer through to all children in `ComponentNode.prototype.createOrUpdateComponent`.
Configuration menu - View commit details
-
Copy full SHA for 3648872 - Browse repository at this point
Copy the full SHA 3648872View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5669af5 - Browse repository at this point
Copy the full SHA 5669af5View commit details -
Enable LOG_VIEW_LOOKUPS for {{outlet}} keyword.
Note: that {{outlet}} templates without a view instance do not get a default view any longer (the template is just rendered).
8Configuration menu - View commit details
-
Copy full SHA for 89cf0a9 - Browse repository at this point
Copy the full SHA 89cf0a9View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 5e1787a - Browse repository at this point
Copy the full SHA 5e1787aView commit details -
Restore Component.prototype.targetObject.
This is needed to target the parentView.controller with the action (when it is provided in the template). It is possible that in 2.x this conceptually needs to change from `parentView.controller` to something else, but the general idea will still remain.
Configuration menu - View commit details
-
Copy full SHA for d22789e - Browse repository at this point
Copy the full SHA d22789eView commit details
Commits on Apr 8, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 386d8e7 - Browse repository at this point
Copy the full SHA 386d8e7View commit details -
Stream dependencies now mock the Stream interface which accomodates some leaner code. Stream now has a revalidate hook which is used for manual dependency management. This hook is invoked in two cases: 1. The stream just activated. 2. The stream is already activate and is about to re-compute.
Configuration menu - View commit details
-
Copy full SHA for f12ae8b - Browse repository at this point
Copy the full SHA f12ae8bView commit details -
Add deactivate hook in Stream, fix KeyStream observers lifecycle
The commit ensures observers for a KeyStream are removed correctly. A new revalidate hook was introduced as a place to clean up any manual dependencies. This hook is invoked when the last subscriber is removed (including when the stream is being destroyed).
Configuration menu - View commit details
-
Copy full SHA for 218eab7 - Browse repository at this point
Copy the full SHA 218eab7View commit details
Commits on Apr 9, 2015
-
Configuration menu - View commit details
-
Copy full SHA for c8e340b - Browse repository at this point
Copy the full SHA c8e340bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa9ccb5 - Browse repository at this point
Copy the full SHA fa9ccb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbb7dae - Browse repository at this point
Copy the full SHA dbb7daeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50d54c1 - Browse repository at this point
Copy the full SHA 50d54c1View commit details -
This commit modifies the AST transforms to match the Handlebars 3.0 AST.
Configuration menu - View commit details
-
Copy full SHA for 826c31f - Browse repository at this point
Copy the full SHA 826c31fView commit details
Commits on Apr 10, 2015
-
And remove the workarounds from it being wrong.
Configuration menu - View commit details
-
Copy full SHA for be60dae - Browse repository at this point
Copy the full SHA be60daeView commit details
Commits on Apr 11, 2015
-
Configuration menu - View commit details
-
Copy full SHA for b857386 - Browse repository at this point
Copy the full SHA b857386View commit details -
Configuration menu - View commit details
-
Copy full SHA for e697ef3 - Browse repository at this point
Copy the full SHA e697ef3View commit details
Commits on Apr 12, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 5d95e7b - Browse repository at this point
Copy the full SHA 5d95e7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 51a560a - Browse repository at this point
Copy the full SHA 51a560aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e01d5df - Browse repository at this point
Copy the full SHA e01d5dfView commit details -
I don't see a reason to bend over backwards to support the exact same assertion language for this (deprecated) feature. This new message is sufficiently clear.
1Configuration menu - View commit details
-
Copy full SHA for a770db3 - Browse repository at this point
Copy the full SHA a770db3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cb9069 - Browse repository at this point
Copy the full SHA 2cb9069View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7487ffb - Browse repository at this point
Copy the full SHA 7487ffbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e90220 - Browse repository at this point
Copy the full SHA 0e90220View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7936130 - Browse repository at this point
Copy the full SHA 7936130View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b9d27e - Browse repository at this point
Copy the full SHA 2b9d27eView commit details
Commits on Apr 13, 2015
-
Configuration menu - View commit details
-
Copy full SHA for c3ae1ad - Browse repository at this point
Copy the full SHA c3ae1adView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1ff5b3 - Browse repository at this point
Copy the full SHA c1ff5b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26438c4 - Browse repository at this point
Copy the full SHA 26438c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e926e8a - Browse repository at this point
Copy the full SHA e926e8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d13a124 - Browse repository at this point
Copy the full SHA d13a124View commit details
Commits on Apr 14, 2015
-
Merge branch 'master-before-tomhuda' into ir-before-tomhuda
Conflicts: packages/ember-routing-htmlbars/lib/helpers/render.js packages/ember-template-compiler/lib/plugins/transform-each-in-to-hash.js packages/ember-views/lib/attr_nodes/attr_node.js
Configuration menu - View commit details
-
Copy full SHA for 31168bb - Browse repository at this point
Copy the full SHA 31168bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce6c868 - Browse repository at this point
Copy the full SHA ce6c868View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81d17c5 - Browse repository at this point
Copy the full SHA 81d17c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d842b6 - Browse repository at this point
Copy the full SHA 1d842b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ef586a - Browse repository at this point
Copy the full SHA 3ef586aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e52034 - Browse repository at this point
Copy the full SHA 5e52034View commit details -
This commit also adds several tests for the path and helper usages of the subexpression form, e.g. ```hbs {{capitalize (unbound foo)}} ``` and ```hbs {{capitalize (unbound if foo bar baz)}} ```
Configuration menu - View commit details
-
Copy full SHA for 508d9de - Browse repository at this point
Copy the full SHA 508d9deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36225a2 - Browse repository at this point
Copy the full SHA 36225a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad7e537 - Browse repository at this point
Copy the full SHA ad7e537View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66acf7f - Browse repository at this point
Copy the full SHA 66acf7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 764a138 - Browse repository at this point
Copy the full SHA 764a138View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c8c573 - Browse repository at this point
Copy the full SHA 0c8c573View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8728fd1 - Browse repository at this point
Copy the full SHA 8728fd1View commit details
Commits on Apr 15, 2015
-
Configuration menu - View commit details
-
Copy full SHA for c692bd0 - Browse repository at this point
Copy the full SHA c692bd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6153cd8 - Browse repository at this point
Copy the full SHA 6153cd8View commit details -
Unify legacy class binding into AST preprocessor
There are several paths and microsyntaxes for creating class name bindings for a component’s element via Handlebars. For example: `{{view ‘my-view’ class=“hello” classBindings=“:foo isApp:is-an-app”}}` With HTMLbars, these have been deprecated in favor of a single API: `{{view class=“hello foo (if isApp ‘is-an-app’)”}}` This commit rewrites the AST of templates that contain the old syntax into the new syntax at template compile time.
Configuration menu - View commit details
-
Copy full SHA for 47ddf42 - Browse repository at this point
Copy the full SHA 47ddf42View commit details -
ContainerView should inherit from View
While it was a noble effort, the attempt to have ContainerView subclass Component did not work because it broke propagation of the `controller` template keyword.
Configuration menu - View commit details
-
Copy full SHA for 8e56b7f - Browse repository at this point
Copy the full SHA 8e56b7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2823dd9 - Browse repository at this point
Copy the full SHA 2823dd9View commit details
Commits on Apr 16, 2015
-
Updates HTMLBars to ensure that initially undefined/null `attributeBindings` are not set on the views element.
Configuration menu - View commit details
-
Copy full SHA for 9efd004 - Browse repository at this point
Copy the full SHA 9efd004View commit details -
Configuration menu - View commit details
-
Copy full SHA for b07d55c - Browse repository at this point
Copy the full SHA b07d55cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c33444 - Browse repository at this point
Copy the full SHA 9c33444View commit details -
Merge pull request #10886 from mitchlloyd/html-class-spacing
Fix class spacing for classNameBindings
Configuration menu - View commit details
-
Copy full SHA for 55ece9f - Browse repository at this point
Copy the full SHA 55ece9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c43cb49 - Browse repository at this point
Copy the full SHA c43cb49View commit details -
Update link-render-node to handle missing params.
The `{{component}}` keyword specifies `null` as `params` (since a component cannot receive ordered arguments). This commit simply adds a guard to ensure we do not attempt to access `params.length` when `params` is `null`.
Configuration menu - View commit details
-
Copy full SHA for 6ff3999 - Browse repository at this point
Copy the full SHA 6ff3999View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2a9f02 - Browse repository at this point
Copy the full SHA d2a9f02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 188d00c - Browse repository at this point
Copy the full SHA 188d00cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ce2845 - Browse repository at this point
Copy the full SHA 9ce2845View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6deadbe - Browse repository at this point
Copy the full SHA 6deadbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for db465ae - Browse repository at this point
Copy the full SHA db465aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for c7f67e8 - Browse repository at this point
Copy the full SHA c7f67e8View commit details -
this is all old implementation of pre-glimmer outlet behavior
Configuration menu - View commit details
-
Copy full SHA for a180c80 - Browse repository at this point
Copy the full SHA a180c80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86bdbc6 - Browse repository at this point
Copy the full SHA 86bdbc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85ff427 - Browse repository at this point
Copy the full SHA 85ff427View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cde4d3 - Browse repository at this point
Copy the full SHA 8cde4d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c056148 - Browse repository at this point
Copy the full SHA c056148View commit details -
Merge pull request #10888 from mitchlloyd/is-visible-fixes
isVisible fixes
Configuration menu - View commit details
-
Copy full SHA for 7324b93 - Browse repository at this point
Copy the full SHA 7324b93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55dd117 - Browse repository at this point
Copy the full SHA 55dd117View commit details
Commits on Apr 17, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 62df0e5 - Browse repository at this point
Copy the full SHA 62df0e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8a8679 - Browse repository at this point
Copy the full SHA d8a8679View commit details -
Configuration menu - View commit details
-
Copy full SHA for 701f11f - Browse repository at this point
Copy the full SHA 701f11fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03c1710 - Browse repository at this point
Copy the full SHA 03c1710View commit details -
Fix a test using an undefined context
Context-changing helpers no longer allow an undefined context. Instead, null is substituted for the context.
Configuration menu - View commit details
-
Copy full SHA for f73264d - Browse repository at this point
Copy the full SHA f73264dView commit details -
Remove ember-metal-views tests
These tests were removed because they were only testing a stub renderer defined in the tests.
Configuration menu - View commit details
-
Copy full SHA for 14d15f4 - Browse repository at this point
Copy the full SHA 14d15f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d342b6 - Browse repository at this point
Copy the full SHA 7d342b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ce75ed - Browse repository at this point
Copy the full SHA 7ce75edView commit details
Commits on Apr 18, 2015
-
Configuration menu - View commit details
-
Copy full SHA for e2ea5f0 - Browse repository at this point
Copy the full SHA e2ea5f0View commit details -
Completely remove the concept of isVirtual
MetamorphView (and the Metamorph mixin) are the final bastion of virtual views. This commit removes much of their use. MetamorphView had two behaviors: First, it was tagless. Second, it was not included in the view hierarchy. The first concept (taglessness) is still valid in Ember post-Glimmer. For this, we use `tagName: ''`. The second concept (virtual views) is not longer present. So views which previously used MetamorphView will not longer be able to escape the view hierarchy. In most cases, the intent was likely to be tagless and being virtual was simply a side effect. OutletView and EachView will now be present in childViews and will be parentViews. `{{render` used to always create a view. Now, it will only create a view if one is set by the user. By default it is only a componentNode and has no view at all. The final spot MetamorphViews are used it for the default itemView and emptyView on EachView. This should be easy to address in a manner similar to {{render: If the user does not specify a view, none should be required. After this, MetamorphView will no longer be used by internals.
Configuration menu - View commit details
-
Copy full SHA for 6368254 - Browse repository at this point
Copy the full SHA 6368254View commit details -
Merge pull request #10903 from mixonic/idempotent-rerender-no-virtual
Completely remove the concept of isVirtual
Configuration menu - View commit details
-
Copy full SHA for 44b219c - Browse repository at this point
Copy the full SHA 44b219cView commit details
Commits on Apr 19, 2015
-
Configuration menu - View commit details
-
Copy full SHA for f892dc8 - Browse repository at this point
Copy the full SHA f892dc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d923a6 - Browse repository at this point
Copy the full SHA 9d923a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a92672 - Browse repository at this point
Copy the full SHA 8a92672View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06aab7c - Browse repository at this point
Copy the full SHA 06aab7cView commit details -
Make createElement work without view entering inDOM state
createElement requires that a view be rendered without the lifecycle hooks being rendered. This leaves it in the hasElement state instead of moving to inDOM as a normal render would.
Configuration menu - View commit details
-
Copy full SHA for 011b876 - Browse repository at this point
Copy the full SHA 011b876View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d3b012 - Browse repository at this point
Copy the full SHA 2d3b012View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09752c4 - Browse repository at this point
Copy the full SHA 09752c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03b420b - Browse repository at this point
Copy the full SHA 03b420bView commit details
Commits on Apr 20, 2015
-
Configuration menu - View commit details
-
Copy full SHA for bbc901d - Browse repository at this point
Copy the full SHA bbc901dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fda7884 - Browse repository at this point
Copy the full SHA fda7884View commit details -
topmost outlet must ensure its child has a DOM element
This keeps us consistent with the DOM structure we produced pre-glimmer. The topmost out ensures that it's child (not itself) always has a real View with an element.
Configuration menu - View commit details
-
Copy full SHA for 5c5585d - Browse repository at this point
Copy the full SHA 5c5585dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b325125 - Browse repository at this point
Copy the full SHA b325125View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ced6d9 - Browse repository at this point
Copy the full SHA 9ced6d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e489a6 - Browse repository at this point
Copy the full SHA 7e489a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d7ec1a - Browse repository at this point
Copy the full SHA 9d7ec1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f11e02a - Browse repository at this point
Copy the full SHA f11e02aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 41648d7 - Browse repository at this point
Copy the full SHA 41648d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05ee711 - Browse repository at this point
Copy the full SHA 05ee711View commit details
Commits on Apr 21, 2015
-
- Rename render_test.js to view_test.js. - Move conatiner view related tests to container_view_test.js. - Remove invalid tests that are overly specific about rerender behaviour. There are much more comprehensive tests in view_lifecycle_test.js.
Configuration menu - View commit details
-
Copy full SHA for 371afb3 - Browse repository at this point
Copy the full SHA 371afb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b1ac59 - Browse repository at this point
Copy the full SHA 9b1ac59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37be98e - Browse repository at this point
Copy the full SHA 37be98eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1404ce4 - Browse repository at this point
Copy the full SHA 1404ce4View commit details
Commits on Apr 22, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 54ed612 - Browse repository at this point
Copy the full SHA 54ed612View commit details -
Cancel scheduled view#append on view#remove
If a view is in a ‘preRender’ state (or any state for that matter) attempting to destroy the element will effectively make any pending view#append operations a noop.
Configuration menu - View commit details
-
Copy full SHA for 1f24be6 - Browse repository at this point
Copy the full SHA 1f24be6View commit details -
Destroy ember views in destroy-render-node hook
The way `clearRender` works, it won’t call destroy on the top level view if given `destroySelf` flag set to false. By moving the `view.destroy` call into this hook, we can avoid destroying the top level view when it is being cleared by `clearRender`. The `view.lastResult` check seemed to just happen to work and needed to be changed to get more tests passing.
Configuration menu - View commit details
-
Copy full SHA for 32d625b - Browse repository at this point
Copy the full SHA 32d625bView commit details
Commits on Apr 23, 2015
-
Merge pull request #10924 from mitchlloyd/view-remove-fixes
Get more tests with view#remove working
Configuration menu - View commit details
-
Copy full SHA for 4a072bc - Browse repository at this point
Copy the full SHA 4a072bcView commit details
Commits on Apr 26, 2015
-
Configuration menu - View commit details
-
Copy full SHA for a79c586 - Browse repository at this point
Copy the full SHA a79c586View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4181cc9 - Browse repository at this point
Copy the full SHA 4181cc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96895af - Browse repository at this point
Copy the full SHA 96895afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97fa5ea - Browse repository at this point
Copy the full SHA 97fa5eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for c278ff5 - Browse repository at this point
Copy the full SHA c278ff5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5d76ee - Browse repository at this point
Copy the full SHA e5d76eeView commit details -
Update number of observers in test
It seems that this test was passing in spirit: the number of observers does not increase when rerendering.
Configuration menu - View commit details
-
Copy full SHA for f224f28 - Browse repository at this point
Copy the full SHA f224f28View commit details -
Disallow spaces in classNameBindings property
Interestingly, spaces are allowed when setting classNameBindings on a view inside of a template. {{view classNameBindings="prop:true:false anotherProp:more-true:more-false"}} However, they are not allowed when setting the property on a view class: Ember.View.create({ classNameBindings: 'prop:true:false anotherProp:more-true:more-false' }); To handle both of these cases, we split the incoming classNameBindings property by spaces when using the view keyword.
Configuration menu - View commit details
-
Copy full SHA for c4cf0ef - Browse repository at this point
Copy the full SHA c4cf0efView commit details -
Merge pull request #10957 from mitchlloyd/view-attr-fixes
View attribute fixes
Configuration menu - View commit details
-
Copy full SHA for d739bd0 - Browse repository at this point
Copy the full SHA d739bd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8578ade - Browse repository at this point
Copy the full SHA 8578adeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 210a47c - Browse repository at this point
Copy the full SHA 210a47cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10d0861 - Browse repository at this point
Copy the full SHA 10d0861View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32d8584 - Browse repository at this point
Copy the full SHA 32d8584View commit details
Commits on Apr 27, 2015
-
Configuration menu - View commit details
-
Copy full SHA for af75b40 - Browse repository at this point
Copy the full SHA af75b40View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba5f1cf - Browse repository at this point
Copy the full SHA ba5f1cfView commit details -
Merge pull request #10960 from mitchlloyd/tagless-assertion
Add back assertion for tagless components with classNameBindings
Configuration menu - View commit details
-
Copy full SHA for f9a192a - Browse repository at this point
Copy the full SHA f9a192aView commit details
Commits on Apr 28, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 97c1039 - Browse repository at this point
Copy the full SHA 97c1039View commit details -
Merge pull request #10969 from machty/ir-qp
Get remainder of query_params_test.js passing
Configuration menu - View commit details
-
Copy full SHA for b162d69 - Browse repository at this point
Copy the full SHA b162d69View commit details -
Configuration menu - View commit details
-
Copy full SHA for af5c3ea - Browse repository at this point
Copy the full SHA af5c3eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82b6968 - Browse repository at this point
Copy the full SHA 82b6968View commit details -
Differentiate between mutable and immutable dependencies
this.addDependency now assumes that the dependee is immutable. In particular this means that it no longer returns the Dependency instance. If you need access to the dependency you must now call this.addMutableDependency. This change allows this.addDependency to be a no-op if the passed in object is not a stream. This is useful for subexpression streams to avoid creating unnecessary dependencies for primitive values, as in this example: ```hbs {{concat values sep=','}} ```
Configuration menu - View commit details
-
Copy full SHA for af36378 - Browse repository at this point
Copy the full SHA af36378View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4df3894 - Browse repository at this point
Copy the full SHA 4df3894View commit details -
Configuration menu - View commit details
-
Copy full SHA for d31876a - Browse repository at this point
Copy the full SHA d31876aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3f96a8 - Browse repository at this point
Copy the full SHA a3f96a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for afa1199 - Browse repository at this point
Copy the full SHA afa1199View commit details -
publish glimmer builds to bower
Stanley Stuart committedApr 28, 2015 Configuration menu - View commit details
-
Copy full SHA for f74f109 - Browse repository at this point
Copy the full SHA f74f109View commit details
Commits on Apr 29, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 967fd42 - Browse repository at this point
Copy the full SHA 967fd42View commit details -
Throw when rerender called after rendering
Just before a block is rendered, views are put into a renderedViews list. When `rerender` is called, this list is checked to ensure the view being rerendered has not already been rerendered.
Configuration menu - View commit details
-
Copy full SHA for 6d43084 - Browse repository at this point
Copy the full SHA 6d43084View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79c06f1 - Browse repository at this point
Copy the full SHA 79c06f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d0b5a4 - Browse repository at this point
Copy the full SHA 9d0b5a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab20172 - Browse repository at this point
Copy the full SHA ab20172View commit details -
Add support for intercepting get and set
These hooks are internal-only, not exposed publicly, and are only intended to be used to emulate deprecated functionality for the moment.
Configuration menu - View commit details
-
Copy full SHA for f68ceeb - Browse repository at this point
Copy the full SHA f68ceebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 60dc11f - Browse repository at this point
Copy the full SHA 60dc11fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f0ca068 - Browse repository at this point
Copy the full SHA f0ca068View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8dfd40 - Browse repository at this point
Copy the full SHA c8dfd40View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3ce978 - Browse repository at this point
Copy the full SHA d3ce978View commit details
Commits on Apr 30, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 8732970 - Browse repository at this point
Copy the full SHA 8732970View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b5a6dc - Browse repository at this point
Copy the full SHA 2b5a6dcView commit details -
Merge branch 'master' into idempotent-rerender
Conflicts: packages/ember-views/lib/attr_nodes/legacy_bind.js packages/ember-views/lib/mixins/class_names_support.js packages/ember-views/lib/streams/should_display.js packages/ember-views/lib/views/collection_view.js packages/ember-views/lib/views/core_view.js packages/ember-views/lib/views/select.js
Configuration menu - View commit details
-
Copy full SHA for 5e371c0 - Browse repository at this point
Copy the full SHA 5e371c0View commit details -
Merge pull request #10990 from krisselden/idempotent-rerender
Idempotent rerender
Configuration menu - View commit details
-
Copy full SHA for 6af18a0 - Browse repository at this point
Copy the full SHA 6af18a0View commit details -
* `get` was unused in ember-routing-htmlbars/keywords/action * Indentation was incorrect in ember-htmlbars/tests/integration/mutable_binding_test
Configuration menu - View commit details
-
Copy full SHA for 53e6eba - Browse repository at this point
Copy the full SHA 53e6ebaView commit details -
`typeOf` moved from `ember-metal/utils` to `ember-runtime/utils` as of #10988.
Configuration menu - View commit details
-
Copy full SHA for a2d9a41 - Browse repository at this point
Copy the full SHA a2d9a41View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccc13a6 - Browse repository at this point
Copy the full SHA ccc13a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9eb523 - Browse repository at this point
Copy the full SHA b9eb523View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc97966 - Browse repository at this point
Copy the full SHA dc97966View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85cda2e - Browse repository at this point
Copy the full SHA 85cda2eView commit details
Commits on May 1, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 9c9c45c - Browse repository at this point
Copy the full SHA 9c9c45cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb5f07c - Browse repository at this point
Copy the full SHA cb5f07cView commit details -
Mostly complete impl of mutable bindings
There are two failing tests related to timing and I want to investigate an alternate approach for mutable cells.
Configuration menu - View commit details
-
Copy full SHA for 28f04c6 - Browse repository at this point
Copy the full SHA 28f04c6View commit details -
Don't leak the stream into user code
In the previous commit, mutable bindings had a value() method that was a live reflection of the underlying stream. Those semantics were inconsistent with immutable bindings, which only update during the rendering process and trigger lifecycle hooks. This commit snapshots the value and provides a new mutable cell each time through.
Configuration menu - View commit details
-
Copy full SHA for e922169 - Browse repository at this point
Copy the full SHA e922169View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce28b3c - Browse repository at this point
Copy the full SHA ce28b3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5fe775 - Browse repository at this point
Copy the full SHA d5fe775View commit details -
Merge pull request #10999 from mitchlloyd/fix-create-child-view-tests
Consistently use `parentView` over `_parentView`
Configuration menu - View commit details
-
Copy full SHA for 3ba81e3 - Browse repository at this point
Copy the full SHA 3ba81e3View commit details -
Merge pull request #10991 from mitchlloyd/view-computed-controller
Fix a test for view controller property
Configuration menu - View commit details
-
Copy full SHA for 5725b5c - Browse repository at this point
Copy the full SHA 5725b5cView commit details -
Fallback to "-text-field" component name for unrecognized input type
Previously, using an input type not in the map (such as "email") would cause an exception. This renames the `classification` var to more expressive `componentNameMap`, and turns the map into a whitelist of non-default component names only. Any value of "type" not in that map (or no value for "type") will use the default "-text-field" component name.
5Configuration menu - View commit details
-
Copy full SHA for 5a1c5e1 - Browse repository at this point
Copy the full SHA 5a1c5e1View commit details -
Merge pull request #11004 from bantic/idempotent-rerender-fix-input-t…
…ypes Fallback to "-text-field" component name for unrecognized input type
Configuration menu - View commit details
-
Copy full SHA for 505ec73 - Browse repository at this point
Copy the full SHA 505ec73View commit details
Commits on May 2, 2015
-
Configuration menu - View commit details
-
Copy full SHA for cd81304 - Browse repository at this point
Copy the full SHA cd81304View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f0d4ed - Browse repository at this point
Copy the full SHA 7f0d4edView commit details -
The container view template uses `elementId` as the key for `{{each}}`. We need to ensure that even tagless views have an `elementId`.
Configuration menu - View commit details
-
Copy full SHA for 4507947 - Browse repository at this point
Copy the full SHA 4507947View commit details -
Update remaining skipped
View.prototype.createElement
.* Avoid using `RenderBuffer` * assert the output HTML
Configuration menu - View commit details
-
Copy full SHA for 2b0404b - Browse repository at this point
Copy the full SHA 2b0404bView commit details -
Prevent clobbering attrs with an attr named attrs.
When invoking a component like: ```javascript {{foo-bar attrs="blah"}} ``` We cannot set `this.attrs` to be equal to `"blah"`. This is potentially breaking for folks that have used `attrs` as a single attribute value in the root of a component.
Configuration menu - View commit details
-
Copy full SHA for ea44afb - Browse repository at this point
Copy the full SHA ea44afbView commit details -
Merge pull request #10958 from mixonic/idempotent-rerender-assert-rer…
…ender Throw when rerender called after rendering
Configuration menu - View commit details
-
Copy full SHA for 5700eee - Browse repository at this point
Copy the full SHA 5700eeeView commit details -
Use
indexOf
from EnumerableUtils.It properly defers to the object or polyfil as needed.
Configuration menu - View commit details
-
Copy full SHA for 9aaa8eb - Browse repository at this point
Copy the full SHA 9aaa8ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e66244 - Browse repository at this point
Copy the full SHA 3e66244View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3493fdc - Browse repository at this point
Copy the full SHA 3493fdcView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed43856 - Browse repository at this point
Copy the full SHA ed43856View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac680f4 - Browse repository at this point
Copy the full SHA ac680f4View commit details -
If a stream value results in a proxy, the stream will begin to observe the proxy's content and notify itself if the content changes.
Configuration menu - View commit details
-
Copy full SHA for a4dffa9 - Browse repository at this point
Copy the full SHA a4dffa9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c340bab - Browse repository at this point
Copy the full SHA c340babView commit details -
Merge pull request #11008 from krisselden/idempotent-rerender
Merge master into idempotent rerender
Configuration menu - View commit details
-
Copy full SHA for a3d4eba - Browse repository at this point
Copy the full SHA a3d4ebaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e82692 - Browse repository at this point
Copy the full SHA 8e82692View commit details
Commits on May 3, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 4e585da - Browse repository at this point
Copy the full SHA 4e585daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 18bf2f3 - Browse repository at this point
Copy the full SHA 18bf2f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0df0cd - Browse repository at this point
Copy the full SHA c0df0cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for b12adfb - Browse repository at this point
Copy the full SHA b12adfbView commit details -
Adds a way to reliably read from DOM
The readDOMAttr method on views makes it possible to read an attribute from DOM and update the internal lastValue at the same time. This effectively fixes the fact that some attribute sets are not idempotent, which causes problems for the write-only pure-function rendering model used by Glimmer and React.
Configuration menu - View commit details
-
Copy full SHA for 918f69d - Browse repository at this point
Copy the full SHA 918f69dView commit details -
Use readDOMAttr + attributeBinding for <textarea>.
The new `readDOMAttr` API allows us to remove this manual `value` property binding in `Ember.TextArea`.
Configuration menu - View commit details
-
Copy full SHA for a805745 - Browse repository at this point
Copy the full SHA a805745View commit details -
* Remove 'value' attribute hacks. * Add `AttrMorph.prototype.getContent`.
Configuration menu - View commit details
-
Copy full SHA for 0e674a4 - Browse repository at this point
Copy the full SHA 0e674a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d501df - Browse repository at this point
Copy the full SHA 2d501dfView commit details -
Merge pull request #10977 from fivetanley/bower-idemptotent-rerender
publish idemptotent rerender to bower
Configuration menu - View commit details
-
Copy full SHA for c762400 - Browse repository at this point
Copy the full SHA c762400View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57f05da - Browse repository at this point
Copy the full SHA 57f05daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73881e4 - Browse repository at this point
Copy the full SHA 73881e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4189eb0 - Browse repository at this point
Copy the full SHA 4189eb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1da840 - Browse repository at this point
Copy the full SHA d1da840View commit details -
Configuration menu - View commit details
-
Copy full SHA for de821af - Browse repository at this point
Copy the full SHA de821afView commit details -
Merge pull request #11012 from mixonic/idempotent-rerender-buffer
Bring back the render hook with a pushable buffer
Configuration menu - View commit details
-
Copy full SHA for 86ecba9 - Browse repository at this point
Copy the full SHA 86ecba9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a33e9c - Browse repository at this point
Copy the full SHA 5a33e9cView commit details
Commits on May 4, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 658f260 - Browse repository at this point
Copy the full SHA 658f260View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42b5df0 - Browse repository at this point
Copy the full SHA 42b5df0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f46a23 - Browse repository at this point
Copy the full SHA 4f46a23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cfb2bd - Browse repository at this point
Copy the full SHA 4cfb2bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6795e0b - Browse repository at this point
Copy the full SHA 6795e0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d38b79 - Browse repository at this point
Copy the full SHA 5d38b79View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4f9da4 - Browse repository at this point
Copy the full SHA a4f9da4View commit details -
Remove deprecation on accessing
attrs
in component root.We have not fully fleshed out the transition plan for this. Remove the deprecation until we have...
Configuration menu - View commit details
-
Copy full SHA for b010313 - Browse repository at this point
Copy the full SHA b010313View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0672868 - Browse repository at this point
Copy the full SHA 0672868View commit details -
Don't warn when for-compat stream is not a path
The `(mut foo)` construction is designed to throw an error if you try to do `(mut "foo")`, for obvious reasons. When I wrote that error, I missed an alternative scenario: ```hbs {{!-- component-one: --}} {{!-- bar is not a path here --}} <component-two foo="bat" /> {{!-- component-two: --}} {{!-- attrs.foo is a path here --}} <component-three baz={{mut attrs.foo}} /> ``` In this case, `attrs.foo` is a path, but it directly refers to a string, which is itself not mutable. With angle-bracket components, when `{{mut}}` is explicit, the error still makes sense: `<component-three>` should not try to mutate `attrs.foo` and we should warn as soon as we can. Unfortunately, that logic does not apply to the compatibility work we are doing: ```hbs {{!-- component-one: --}} {{component-two foo="bat"}} {{!-- component-two: --}} {{component-three baz=attrs.foo}} ``` In this case, we can't know ahead of time that `attrs.foo` refers to a non-mutator, so we have to allow for the possibility that this is a two-way binding. For what it's worth, scenarios like this, which are clearly bugs (`component-three` settting `baz`), help to explain the motivation for the change in the first place. This commit adds a private `@mut` that can support the looser semantics of Ember 1.x curly components, while retaining the stricter errors for explicit calls to `mut` used with angle bracket components.
Configuration menu - View commit details
-
Copy full SHA for 807a0cd - Browse repository at this point
Copy the full SHA 807a0cdView commit details -
Intercept property changes instead of sets
(cherry picked from commit b4d53bfd2d2769c4133f5f55e5551c6cc2dc87f8)
Configuration menu - View commit details
-
Copy full SHA for 27a6c57 - Browse repository at this point
Copy the full SHA 27a6c57View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9e5c80 - Browse repository at this point
Copy the full SHA d9e5c80View commit details -
Configuration menu - View commit details
-
Copy full SHA for a233059 - Browse repository at this point
Copy the full SHA a233059View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12b2496 - Browse repository at this point
Copy the full SHA 12b2496View commit details -
Bring Ember._Metamorph and Ember._MetamorphView back and deprecate.
ember-test-helpers still attempts to register `Ember._Metamorph` as `view:default` which causes an error. We will need to update ember-test-helpers to check for its existence first and remove the globals at a later date.
Configuration menu - View commit details
-
Copy full SHA for dddca9a - Browse repository at this point
Copy the full SHA dddca9aView commit details -
Revert "Allow publishing of idempotent-rerender PR to S3."
This reverts commit 12b2496. This was accidentally pushing the glimmer builds to `canary` URL's. Removed for now. Lets just merge this PR....
Configuration menu - View commit details
-
Copy full SHA for ff82f2e - Browse repository at this point
Copy the full SHA ff82f2eView commit details
Commits on May 5, 2015
-
outlet keywords must pass the template to render as template
Previously, they were passing it as layout which smashed a layout that may have existed on the view being rendered.
Configuration menu - View commit details
-
Copy full SHA for f81b17d - Browse repository at this point
Copy the full SHA f81b17dView commit details -
Merge pull request #11022 from mixonic/idempotent-rerender-layout
outlet keywords must pass the template to render as template
Configuration menu - View commit details
-
Copy full SHA for 5bbfe68 - Browse repository at this point
Copy the full SHA 5bbfe68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 535e44b - Browse repository at this point
Copy the full SHA 535e44bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d177ca - Browse repository at this point
Copy the full SHA 4d177caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12cd907 - Browse repository at this point
Copy the full SHA 12cd907View commit details -
Configuration menu - View commit details
-
Copy full SHA for 820d559 - Browse repository at this point
Copy the full SHA 820d559View commit details -
Add test controller propagation from route driven views.
(cherry picked from commit 035545ed2c47b84f1c104d3e22bded6f72db1a37)
Configuration menu - View commit details
-
Copy full SHA for 38a9d86 - Browse repository at this point
Copy the full SHA 38a9d86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 691a5b0 - Browse repository at this point
Copy the full SHA 691a5b0View commit details