Fix a test for view controller property #10991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchlloyd
force-pushed
the
view-computed-controller
branch
from
90a378c
to
120e790
Compare
mitchlloyd
force-pushed
the
view-computed-controller
branch
from
120e790
to
ce28b3c
Compare
rwjblue
added a commit
that referenced
this pull request
May 1, 2015
Fix a test for view controller property
|
👍 |
|
Migrating from 1.11 to 1.13, this notification causes some observers to be fired, even if the controller did not changed at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is tempting to add an observer or use a dependent key for ‘childViews’ on thecontrollercomputed property in ‘view_context_support.js’. However, doing this results in a lot of MANDITORY_SETTER errors since there are a few places in the code that set ‘childViews’ directly.Notify the view of a possible controller change when its parentView changes.