[port] Change the way we set up the port property to be used by logic in the port-mixin #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the port-mixin
RobbieTheWagner
approved these changes
Apr 26, 2019
|
Thanks so much for debugging and fixing this @alexhancock! I really appreciate it! 😃 |
RobbieTheWagner
added a commit
that referenced
this pull request
Apr 26, 2019
* Trying to fix names issue * Attempt to support dynamically added iframes * Trying to fix names issue * Fix inverted if * Fix lint * Fix EMBER_VERSIONS_SUPPORTED * Update tests for new format * Colocate applicationName and applicationId * Revert "Attempt to support dynamically added iframes" This reverts commit e49e485. * Fix inverted if * Trying to get multiple-apps working again * Use app-picker * Remove leftover iframe-picker * Use modulePrefix as well * Add applicationId and applicationName to apps * Fix lint * [port] Change the way we set up the port property to be used by logic in the port-mixin (#969) * Fix lint * Actually fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug with the new application switcher functionality where
this.get('port')was not set at times other code was trying to use it.I removed the
port: readOnly('namespace.port')in all the things that use theport-mixinand set the property in the init method of the mixin itself instead.