Add back support for multiple apps

[RobbieTheWagner]

No description provided.

[RobbieTheWagner]

@rwjblue I was unable to get anything close to functioning here, but hopefully this shows you what I was going for. Perhaps you could help me figure out where I went wrong?

[RobbieTheWagner]

@rwjblue @teddyzeenny @nummi @alexhancock this code seems to work for iframes and multiple apps, but @teddyzeenny was saying the uniqueId stuff was necessary because guidFor has no guarantee of being unique across iframes.

It would be awesome if you guys could take a look at this PR and maybe help with ways to clean things up, thoughts, suggestions etc.

I was hoping we could move some of the manual applicationId and applicationName stuff to be stored on the app instances, which I did in one spot with Object.assign.

[alexhancock]

but @teddyzeenny was saying the uniqueId stuff was necessary because guidFor has no guarantee of being unique across iframes.

That makes sense to me if we actually have code running across multiple execution contexts that guidFor wouldn't be guaranteed to generic unique IDs across them. I'm still learning how the whole architecture works.

Does the logic in ember_debug/port.js actually run in the context of multiple iframes if there are apps in iframes on the page, or is it all run centrally in one context?

[RobbieTheWagner]

@alexhancock the ember_debug code is injected into the iframes, and run in their context, I believe.

ember-inspector/app/adapters/web-extension.js

Line 115 in c207685

chrome.devtools.inspectedWindow.eval(emberDebug, { frameURL: url });

[alexhancock]

@rwwagner90 Ahh, I see. Thanks for clarifying that!

[nummi]

Seems to be working on the Square Dashboard with an iframe inserted into the markup:

My test app has a blank <option> but it still functions:

[alexhancock]

@rwwagner90 Any interest in re-starting this? I think where we left off you wanted a code review from @teddyzeenny?

Seems like we had the solution pretty close in code. I would love to finish it if there is interest.

[RobbieTheWagner]

@alexhancock I do plan to wrap this up soon. I spoke to @teddyzeenny and he is in favor of us shipping more code and worrying about it less. If it breaks things for anyone, hopefully they will report bugs. We currently have a lot of other issues to work through for inspector, and we have to work through those and get the tests passing again, before we can merge any PRs. Would you be interested in looking into some of the issues with us?

[alexhancock]

@rwwagner90 Sounds good. I am happy to spend some time looking into those issues. What's the best way for me to help? Is there a branch I should check out and try to debug things on my own, or should I join to discuss on discord at some time?

I am wrapping up my work day soon today, but should be able to help look into things tomorrow.

[RobbieTheWagner]

@alexhancock I just rebased this with master. Would you mind testing to make sure it works for you?

[alexhancock]

@rwwagner90 sure thing - will test shortly

[alexhancock]

@rwwagner90 Seemed to work well for me. I tested our case where we have two ember apps on the page, and then I dropped an iframe in the page to a third ember app running on my computer, and they all showed up in the picker. When switching back and forth between the apps, I got this error on occasion (not every time):

... but even though I got the error, everything continued to work.

[RobbieTheWagner]

@alexhancock would you possibly be interested in debugging that error and trying to determine what is causing it?

[alexhancock]

@rwwagner90 sure - will look tomorrow.

[RobbieTheWagner]

@alexhancock sounds good! Please keep me posted 😃

[RobbieTheWagner]

@alexhancock any luck?

[alexhancock]

Got a little more clarity on what the error is, but didn't find a solution yet. Had limited time to look at it so far, but will try to figure it out today/tomorrow.

[RobbieTheWagner]

@alexhancock just keep me posted! I would like to get this in soon, and release a new version 😃

[nummi]

Embedded iframe is working for me. We just need someone with multiple apps on one page to test.

[alexhancock]

@nummi @rwwagner90 I tested on our site (https://squareup.com/dashboard/). It works well from what I can see.

If we know of any other cases we should test them, but otherwise I suppose we just go for it?

[RobbieTheWagner]

Merged. Thanks so much guys! If anything breaks, I'm sure people will let us know 😝