Clean up unused manifest property + prevent error in storage lookup #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieTheWagner
approved these changes
Dec 21, 2018
|
Thanks for the PR! |
cyril-sf
pushed a commit
to cyril-sf/ember-inspector
that referenced
this pull request
Mar 30, 2022
…mberjs#899) * remove unused 'browser_style' in metadata's 'options_ui' https://developer.chrome.com/extensions/options#embedded_options * prevent property lookup on undefined option data hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a chrome manifest warning (visible when loading the unpacked extension produced by the steps in the readme) by removing an obsolete
browser_styleproperty from the top leveloptions_uihash:Per the docs this property is no longer used, removing it has no effect as the default when specifying the options menu using
options_ui(embedded) - as opposed to simplyoptions_page(full page) - is this "modal" style options dialog:There is also the option top explicitly set the
options_ui.open_in_tabproperty to false. Would we prefer to be explicit or rely on the default here?While working on a different issue I noticed a background script error caused by attempting to access a
showTomsterproperty of undefined so I've added a guard inside thechrome.storage.sync.getcall for when our options haven't yet been initialised (before the first user prompted call tostoreOptionssets the correct structure). I'm happy to move this change out into a different PR / drop it if you'd prefer.