Clean up unused manifest property + prevent error in storage lookup (e…

…mberjs#899) * remove unused 'browser_style' in metadata's 'options_ui' https://developer.chrome.com/extensions/options#embedded_options * prevent property lookup on undefined option data hash
cyril-sf · Mar 30, 2022 · 5b41fe8 · 5b41fe8
1 parent a13a8f1
commit 5b41fe8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/skeletons/web-extension/manifest.json b/skeletons/web-extension/manifest.json
@@ -45,7 +45,6 @@
   ],
 
   "options_ui": {
-    "page": "options-dialog.html",
-    "browser_style": true
+    "page": "options-dialog.html"
   }
 }
diff --git a/skeletons/web-extension/options.js b/skeletons/web-extension/options.js
@@ -18,7 +18,7 @@
     chrome.storage.sync.get('options', function(data) {
       var options = data.options;
 
-      document.querySelector('[data-settings=tomster]').checked = options.showTomster;
+      document.querySelector('[data-settings=tomster]').checked = options && options.showTomster;
     });
   }