Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply classes to get back record colors #888

Merged
merged 1 commit into from
Dec 2, 2018
Merged

Apply classes to get back record colors #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 0 additions & 41 deletions app/components/record-item.js
View file
Open in desktop

This file was deleted.

20 changes: 16 additions & 4 deletions app/styles/ember-table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,22 @@
border-right: 1px solid var(--base03);
}

.blue {
color: #174fff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: ;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix in a follow up, and add stylelint to catch these things 👍

}

.green {
color: #009900;
}

.red {
color: #ff2717;
}

th.is-sortable:hover {
background: #e9f4fc
}


.et-sort-indicator:before {
display: inline-block;
Expand All @@ -66,7 +78,7 @@
}

&.is-resizing * {
cursor: col-resize!important;
cursor: col-resize !important;
user-select: none
}

Expand All @@ -81,7 +93,7 @@
border-right: none;
opacity: .8;
z-index: 10;

th {
background: #e9f4fc
}
Expand All @@ -98,7 +110,7 @@
}

&.is-reordering * {
cursor: grabbing!important;
cursor: grabbing !important;
user-select: none
}

Expand Down
5 changes: 0 additions & 5 deletions app/templates/components/record-item.hbs
View file
Open in desktop

This file was deleted.

6 changes: 5 additions & 1 deletion app/templates/records.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@
{{/t.head}}
{{#t.body rows=filtered checkboxSelectionMode="none" selection=selection onSelect=(action "inspectModel") as |b|}}
{{#b.row class=(if (mod b.rowMeta.index 2) "striped") data-test-table-row="" as |r|}}
{{r.cell data-test-table-cell=""}}
{{#r.cell data-test-table-cell="" as |value column row|}}
<span class="{{row.color}}">
{{value}}
</span>
{{/r.cell}}
{{/b.row}}
{{/t.body}}
{{/ember-table}}