Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply classes to get back record colors #888

Merged
merged 1 commit into from
Dec 2, 2018
Merged

Conversation

RobbieTheWagner
Copy link
Member

@RobbieTheWagner RobbieTheWagner commented Dec 1, 2018

With the switch to ember-table, we lost the text colors for new, modified, etc records. This adds them back.

Copy link
Contributor

@pbishop16 pbishop16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor comment.

@@ -43,10 +43,22 @@
border-right: 1px solid var(--base03);
}

.blue {
color: #174fff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: ;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix in a follow up, and add stylelint to catch these things 👍

Copy link
Member

@thorsteinsson thorsteinsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobbieTheWagner RobbieTheWagner merged commit 2179430 into master Dec 2, 2018
@RobbieTheWagner RobbieTheWagner deleted the fix-record-colors branch December 2, 2018 01:55
cyril-sf pushed a commit to cyril-sf/ember-inspector that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants