Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Fix default blueprint by specifying source. #73

Merged
merged 1 commit into from
Aug 5, 2015

Conversation

blimmer
Copy link
Contributor

@blimmer blimmer commented Aug 5, 2015

Fixes #72

@stefanpenner
Copy link
Contributor

hold of on this for now, @mike-north and myself are looking into the source of the issue.

@stefanpenner
Copy link
Contributor

after a deep dive the correct solution is actually, omit source and use name without the user/org prefix

 { name: 'ember-cli-test-loader', target: '0.1.3'  }

bower actually cares about source, but accepts name and will do magic to resolve the correct source from the name. The caveat is, bower will allow you to also specify an explicit source allowing you to re-name the route bower_components directory the dependency will live in.

for example:

 { name: 'a', target: '0.1.3' , source: 'ember-cli/ember-cli-test-loader' },
 { name: 'b', target: '0.1.2' , source: 'ember-cli/ember-cli-test-loader' }

should result in:

bower_components/a <version 0.1.3>
bower_components/b <version 0.1.2>

@blimmer
Copy link
Contributor Author

blimmer commented Aug 5, 2015

This will work because ember-cli-test-loader is published to the bower registry. On Ember CLI Mocha we have the issue of relying on ember-cli-shims which is not published to the bower registry and no longer resolves with the repo/project-name format. I think, in that case, that we need source, right?

@blimmer
Copy link
Contributor Author

blimmer commented Aug 5, 2015

I've also changed this PR to your suggestion, Stef!

@stefanpenner
Copy link
Contributor

I think, in that case, that we need source, right?

yes, you are correct. For things not published to bower, source should be set.

@stefanpenner
Copy link
Contributor

LVGTM

stefanpenner added a commit that referenced this pull request Aug 5, 2015
Fix default blueprint by specifying source.
@stefanpenner stefanpenner merged commit 13fe6ce into ember-cli:master Aug 5, 2015
@blimmer
Copy link
Contributor Author

blimmer commented Aug 5, 2015

Thanks for the explanations and quick turnaround on this.

@stefanpenner
Copy link
Contributor

@blimmer sorry for the original issue, it appears are historic usage of bower was in error.

We should release shims to bower and then source is also not needed for that.

@ballPointPenguin
Copy link

heh heh. #71

Thanks, @blimmer

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants