Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Fix bower install #69

Merged
merged 2 commits into from
Aug 5, 2015
Merged

Fix bower install #69

merged 2 commits into from
Aug 5, 2015

Conversation

blimmer
Copy link
Contributor

@blimmer blimmer commented Aug 5, 2015

No description provided.

return addonContext.removePackageFromProject('ember-cli-qunit');
}
});
return this.addBowerPackagesToProject([
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was broken by this changeset in ember-cli.

@blimmer
Copy link
Contributor Author

blimmer commented Aug 5, 2015

This is a quick fix, but @stefanpenner and I agree the old way should still work. With that said, this will fix the issue for those trying to use this project with today's flavor of ember-cli.

dgeb added a commit that referenced this pull request Aug 5, 2015
@dgeb dgeb merged commit 2a6051f into ember-cli:master Aug 5, 2015
@dgeb
Copy link
Member

dgeb commented Aug 5, 2015

Thanks @blimmer!

Published in v0.9.2.

@stefanpenner
Copy link

this fix works, but only the source for `ember-cli-shims' needs to be specified since it is not published to bower (yet). The rest don't need source.

Some further context: ember-cli/ember-cli-qunit#73 (comment)

@stefanpenner
Copy link

If someone wants to publish shims to bower, we can drop the source here too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants