Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

325 stograge entity is not exported correctly #326

Merged
merged 6 commits into from
Feb 23, 2022

Conversation

vildead
Copy link
Member

@vildead vildead commented Feb 10, 2022

The platform now contains correct value - name of the backend used for storage of the data

Users with access were not listed in the exported JSON. I have added both user and contact.

There will be more work needed:

  1. exported JSON contains "storages", but in fact, these are exported from Accesses. If a storage is not set for Access instance, the record is not exported.
  2. user and contact entity should be imho merged in some way. - e.g contact has fields first name and last name but for user, only full name is available

@vildead vildead linked an issue Feb 10, 2022 that may be closed by this pull request
2 tasks
@vildead vildead force-pushed the 325-stograge-entity-is-not-exported-correctly branch from ede4b46 to c1904ab Compare February 17, 2022 09:25
@vildead
Copy link
Member Author

vildead commented Feb 17, 2022

@jLebioda could you please confirm? This is just a quick fix of exporter so Valentin can continue with E2E. Thanks!

Copy link
Collaborator

@jLebioda jLebioda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
One comment though - is there any specific reason to call:

"pk": self.id.__str__(),

# instead of:
"pk": str(self.id),

# or 
"pk": f"{self.id}",

@vildead
Copy link
Member Author

vildead commented Feb 23, 2022

thanks

Looks good! One comment though - is there any specific reason to call:

"pk": self.id.__str__(),

# instead of:
"pk": str(self.id),

# or 
"pk": f"{self.id}",

Thanks for review @jacek

@vildead vildead merged commit 89fc6ed into develop Feb 23, 2022
@vildead vildead mentioned this pull request Feb 23, 2022
3 tasks
@vildead vildead deleted the 325-stograge-entity-is-not-exported-correctly branch July 22, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage entity is not exported correctly
2 participants