Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage entity is not exported correctly #325

Closed
2 tasks done
vildead opened this issue Feb 9, 2022 · 3 comments · Fixed by #326
Closed
2 tasks done

Storage entity is not exported correctly #325

vildead opened this issue Feb 9, 2022 · 3 comments · Fixed by #326
Assignees
@vildead
Labels
blocker The issue is of most importance

Comments

@vildead
Copy link
Member

vildead commented Feb 9, 2022 •
edited
Loading

The storage platform and version of data is assigned wrong keys in exported JSON.

  • fix so keys and values match
  • check why schema validator did not discover this? Is the schema not restrictive enough?

153237834-186cd0dd-a3d9-4f37-9407-725483f317d5
@vildead vildead added the blocker The issue is of most importance label Feb 9, 2022
@jLebioda
Copy link
Collaborator

jLebioda commented Feb 9, 2022 •
edited
Loading

The storage platform and version of data is assigned wrong keys in exported JSON.

  • [] fix so keys and values match
  • [] check why schema validator did not discover this? Is the schema not restrictive enough?

153237834-186cd0dd-a3d9-4f37-9407-725483f317d5

@vildead vildead linked a pull request Feb 10, 2022 that will close this issue
325 stograge entity is not exported correctly #326
Merged
@vildead vildead self-assigned this Feb 10, 2022
@vildead
Copy link
Member Author

vildead commented Feb 10, 2022

the storages object in JSON is populated from Access instances. This is imho wrong as when there is no access registered for an existing storage (copy of the data), it is not exported.

I suggest to add "accesses" into the schema. Storages will then list only storage locations while accesses can have a field where the storage id or name/location/details will be recorded.

@vildead
Copy link
Member Author

vildead commented Feb 10, 2022

  • remove user access from the storages
  • collect storages from storages not from accesses
  • place accesses on the same level as storages - include link to storages
  • add storage resource id in exported storages

@vildead vildead mentioned this issue Sep 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vildead vildead

Labels
blocker The issue is of most importance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

325 stograge entity is not exported correctly elixir-luxembourg/daisy
2 participants
@jLebioda @vildead