-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
207 remove uniqueness constraint on data declaration title #268
207 remove uniqueness constraint on data declaration title #268
Conversation
data declaration is now uniquely defined by both title AND containing dataset
@vildead I tried editing the existing data declaration "ChIP-Seq, RNA-seq", just tried changing it's title. I got this error: 'DataDeclarationEditForm' object has no attribute 'dataset' |
Also, I tried adding 2 new data declaration sto the Epic DREM sequencing dataset (from teh demo data). I used the name "test" for both declarations. I got the error " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR branch breaks in multiple ways on my machine. Details are in the conversation tab.
data declaration unique title validation now uses instance to retrieve onwning dataset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editor error is eliminated. And we agreed that control for DDEC uniqueness within a DSET will be kept. Thanks @vildead .
No description provided.