Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

207 remove uniqueness constraint on data declaration title #268

Merged

Conversation

vildead
Copy link
Member

@vildead vildead commented Jul 29, 2021

No description provided.

@vildead vildead linked an issue Jul 29, 2021 that may be closed by this pull request
@pinarpink pinarpink self-requested a review July 29, 2021 11:15
@pinarpink
Copy link
Member

pinarpink commented Jul 30, 2021

@vildead I tried editing the existing data declaration "ChIP-Seq, RNA-seq", just tried changing it's title. I got this error:

'DataDeclarationEditForm' object has no attribute 'dataset'

@pinarpink
Copy link
Member

Also, I tried adding 2 new data declaration sto the Epic DREM sequencing dataset (from teh demo data). I used the name "test" for both declarations. I got the error "Data declaration with the same title already exists for the dataset. " when adding the second declaration. @vildead

Copy link
Member

@pinarpink pinarpink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR branch breaks in multiple ways on my machine. Details are in the conversation tab.

data declaration unique title validation now uses instance to retrieve
onwning dataset
@vildead vildead requested a review from pinarpink July 30, 2021 11:39
Copy link
Member

@pinarpink pinarpink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editor error is eliminated. And we agreed that control for DDEC uniqueness within a DSET will be kept. Thanks @vildead .

@vildead vildead changed the title 207 remove unqiueness constraint on data declaration title 207 remove uniqueness constraint on data declaration title Aug 2, 2021
@vildead vildead merged commit 80f5897 into develop Aug 2, 2021
@vildead vildead deleted the 207-remove-unqiueness-constraint-on-data-declaration-title branch July 22, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unqiueness constraint on Data Declaration title
2 participants