Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unqiueness constraint on Data Declaration title #207

Closed
pinarpink opened this issue Apr 8, 2021 · 2 comments · Fixed by #268
Closed

Remove unqiueness constraint on Data Declaration title #207

pinarpink opened this issue Apr 8, 2021 · 2 comments · Fixed by #268
Assignees
@vildead
Labels
major The issue is of big importance
Milestone
ELIXIR End2End M1

Comments

@pinarpink
Copy link
Member

We run into this issue in real-world submissions. Data declarations may not have a unique name.
@pinarpink pinarpink added discuss This issue requires discussion major The issue is of big importance labels Apr 8, 2021
@jLebioda
Copy link
Collaborator

Unfortunately, I think it will not be one-liner fix (in the importer we use DataDeclaration.objects.get(title=... which will break once the titles are not unique); or is it irrelevant?

@pinarpink pinarpink added this to the ELIXIR End2End M1 milestone Jun 3, 2021
@vildead vildead self-assigned this Jul 20, 2021
@vildead
Copy link
Member

vildead commented Jul 20, 2021

Importer will indeed need to be checked - DD should be always matched by title + owning dataset name/accession number.

@vildead vildead removed the discuss This issue requires discussion label Jul 20, 2021
@vildead vildead linked a pull request Jul 29, 2021 that will close this issue
207 remove uniqueness constraint on data declaration title #268
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vildead vildead

Labels
major The issue is of big importance
Projects
None yet
Milestone
ELIXIR End2End M1
Development

Successfully merging a pull request may close this issue.

207 remove uniqueness constraint on data declaration title elixir-luxembourg/daisy
3 participants
@pinarpink @jLebioda @vildead