Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes: 25 compact editor forms #161

Merged
merged 22 commits into from
Apr 27, 2020
Merged

closes: 25 compact editor forms #161

merged 22 commits into from
Apr 27, 2020

Conversation

jLebioda
Copy link
Collaborator

@jLebioda jLebioda commented Apr 23, 2020

Multiple UI tweaks. The list include:

in the editor form

  • removed big block which occupies vertical space; instead only header is used
  • reduced the padding-top in the edit boxes
  • reduced the dimensions of textareas - down to 2 rows (much smaller in height)
  • made save buttons block buttons (occupy the whole width)

in the list view:

  • corrected formatting, it's clearer
  • adjusted widths of the boxes on the left (longer filters do not need to be wrapped now) and right (browsed items)
  • when viewport is small (mobile), the filters on the left disappear, and the filter button appears next to Add new
  • adjusted margin of sort buttons (it matches items below)
  • added help icon to help block in the top section
  • lowercase in help block: Use the categories on the left or the search box below to locate contracts instead of ...Contracts
  • added information on how to add a new item (mentioned button on bottom-right)

Screenshot 2020-04-23 at 16 50 56

Screenshot 2020-04-23 at 16 51 20

Closes #25

@jLebioda
Copy link
Collaborator Author

Moreover, the modal boxes are wider:

Screenshot 2020-04-23 at 17 03 28

@vildead
Copy link
Member

vildead commented Apr 23, 2020

the modal boxes and editors look really much better! :) they are more compact and ... professional 🥇
list view is also better with items less spaced 👍 nevertheless they will need some tweaking imho. Once we come up with more specific design changes :)

Just one minor thing, in dataset page, header for data declarations is with light grey backround. While the rest of boxes (legal basis, storage, access,... ) has headers with no background. Is it on purpose?
I would vote for consistent style of boxes with tables.

@jLebioda
Copy link
Collaborator Author

In fact the headers had different colors; I've corrected them as well:
Screenshot 2020-04-23 at 22 01 38

Thanks for watchfulness :)

Copy link
Member

@pinarpink pinarpink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jLebioda It is tighter and much much better. I only have one comment. The "LaySummary" field is a single line, only for that one, several lines may be necessary. Thank you so much.

@jLebioda
Copy link
Collaborator Author

OK, I've increased the height of lay-summary to six lines; that should be enough

@pinarpink
Copy link
Member

@jLebioda thanks a lot. That'll be more than enough.

@jLebioda jLebioda merged commit 91578ba into develop Apr 27, 2020
@pinarpink pinarpink deleted the 25-compact-editor-forms branch June 19, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compact editor forms
3 participants