Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact editor forms #25

Closed
pinarpink opened this issue Jun 15, 2019 · 6 comments · Fixed by #161
Closed

Compact editor forms #25

pinarpink opened this issue Jun 15, 2019 · 6 comments · Fixed by #161
Assignees
Labels
discuss This issue requires discussion enhancement New feature or request major The issue is of big importance wip Work In Progress
Milestone

Comments

@pinarpink
Copy link
Member

Vertical space needs to be reduced. Also form fields can be displayed in a double column.
Scrolling to see more fields should be as minimised as possible.

@kavitarege kavitarege self-assigned this Jul 3, 2019
@pinarpink pinarpink added this to the m_02 milestone Jul 16, 2019
@pinarpink
Copy link
Member Author

Based on DAISY use sessions with research groups, this has become much more urgent. We have scroll way too much to document data declaration characteristics

@pinarpink pinarpink added enhancement New feature or request major The issue is of big importance discuss This issue requires discussion labels Jan 8, 2020
@jLebioda jLebioda self-assigned this Jan 30, 2020
@jLebioda jLebioda added the wip Work In Progress label Jan 30, 2020
@jLebioda
Copy link
Collaborator

jLebioda commented Feb 6, 2020

Working on that on 25-compact-editor-forms.

Is it just me, or don't you think that it's less readable now?
image

@jLebioda
Copy link
Collaborator

jLebioda commented Feb 6, 2020

at this moment it looks like that:
image

@pinarpink
Copy link
Member Author

@jLebioda agree with you, less readable. Double columns should only be used when the two fields are closely related e.g. start date and end date in the Project editor.

Also we have these grey areas which wrap each field [label+input+help text], if we can minimise the margins on those that could also help.

Another way to obtain space is to not have a 10-12 line text area for free text fields, which are often empty or contain a sentence or two.

@jLebioda
Copy link
Collaborator

jLebioda commented Apr 23, 2020

  • removed the big block from edit pages
  • reduced the margin-top of the form blocks
  • reduced the size of textareas - they resemble edit boxes (only 2 lines of height)

Current: Screenshot 2020-04-23 at 13 24 30

Proposed change: Screenshot 2020-04-23 at 13 24 44

@jLebioda
Copy link
Collaborator

jLebioda commented Apr 23, 2020

I tried to make the structure slightly more logical - there was a mess of different column widths and alignments. For sure more tweaks are needed (e.g. vertical align of search and sort buttons), but one step at a time :)

Before:
Screenshot 2020-04-23 at 14 56 31

After:
Screenshot 2020-04-23 at 14 56 47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss This issue requires discussion enhancement New feature or request major The issue is of big importance wip Work In Progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants