-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry support #229
Comments
I think some default interceptors would do just fine, although perhaps we can have events being published directly by the core server and client functions. I would have something like |
I want to start something simple like execution time such as I would prototype this feature to see how it going and discuss a bit more in details. :) |
Those make sense, although I would use [:grpc, :server, :request] as the name of the event (to which telemetry span would append start and stop and exception). I think we should include the stream as part of the metadata. I think it's basically a mixture of what Tesla and Phoenix do with Telemetry. Since client-server connections aren't necessarily related to each request, we should perhaps add separate events for connect and disconnect on both sides as well |
@wingyplus to be clear, I think we're ready for a PR on these events :) |
Yeah. I’ll looking into it after setup ci is done. :) |
As a point of reference, I'll work to publish events so we can export all metrics that grpc_prometheus currently exports |
It would be good if have telemetry support for this library. I'm not sure if interceptor is a good fit but we can start from that.
The text was updated successfully, but these errors were encountered: