Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase maximum for zoom plugin #877

Merged
merged 6 commits into from
Jul 21, 2020

Conversation

meisenzahl
Copy link
Member

@meisenzahl meisenzahl commented Jul 19, 2020

Closes #876

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for working on this!

I’m not sure this really needs to be configurable. The user already configures their zoom level as they use the feature. So it would probably be more immediately useful to add more steps without any configuration

@meisenzahl
Copy link
Member Author

@mmohsinkhan has described that he needs at least a zoom factor of 6.0f. Should the maximum then be even higher, e.g. 10.0f? Should the step size still be 0.5f?

@meisenzahl meisenzahl changed the title Make zoom factor and zoom step size adjustable Increase maximum for zoom plugin Jul 19, 2020
@mmohsinkhan
Copy link

Max magnification factor 2.5f set currently is not enough for people like me. I need to magnify desktop more than 2.5 times to make it usable for me.
I don't think setting max factor to 10f would do any harm, on the bright people like me would be able to use Elementary out of the box.

Thanks

@meisenzahl meisenzahl marked this pull request as ready for review July 20, 2020 10:25
@cassidyjames cassidyjames requested a review from danirabbit July 20, 2020 20:06
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Seems to work as expected. Thanks for creating this pull request.

I have one tiny inline suggestion while we're here. It might be nice to have a little bit of feedback when we reach the limit :)

plugins/zoom/Main.vala Show resolved Hide resolved
meisenzahl and others added 2 commits July 21, 2020 20:37
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks for fixing this :)

@meisenzahl
Copy link
Member Author

The solution was much easier than I thought #Bitesize

@danirabbit danirabbit merged commit 203e93c into elementary:master Jul 21, 2020
@mmohsinkhan
Copy link

Thanks guys for the support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase zoom factor in Gala's Zoom plugin
4 participants