-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase maximum for zoom plugin #877
Increase maximum for zoom plugin #877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for working on this!
I’m not sure this really needs to be configurable. The user already configures their zoom level as they use the feature. So it would probably be more immediately useful to add more steps without any configuration
@mmohsinkhan has described that he needs at least a zoom factor of |
Max magnification factor 2.5f set currently is not enough for people like me. I need to magnify desktop more than 2.5 times to make it usable for me. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Seems to work as expected. Thanks for creating this pull request.
I have one tiny inline suggestion while we're here. It might be nice to have a little bit of feedback when we reach the limit :)
Co-authored-by: Daniel Foré <daniel@elementary.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks for fixing this :)
The solution was much easier than I thought #Bitesize |
Thanks guys for the support. |
Closes #876