Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase zoom factor in Gala's Zoom plugin #876

Closed
mmohsinkhan opened this issue Jul 18, 2020 · 6 comments · Fixed by #877
Closed

Increase zoom factor in Gala's Zoom plugin #876

mmohsinkhan opened this issue Jul 18, 2020 · 6 comments · Fixed by #877

Comments

@mmohsinkhan
Copy link

mmohsinkhan commented Jul 18, 2020

I am a software developer with eye sight problem, I need screen magnification to carry out routine work on my computer.

Screen magnification works on Elementary OS but current max magnification factor (2.5 times) is not enough for me. Please make it at least 6 times. If required I can open Pull Request with increased magnification factor.

For now I have build and installed gala from source after increasing magnification factor.

Best Regards

@meisenzahl
Copy link
Member

I saw your post on Reddit some time ago and actually wanted to create an issue here. Good that you were faster 😀️

How did you implement it? Did you just increase the maximum zoom factor to 6.0f?

else if (current_zoom >= 2.5f && @in)
return;

So you can now increase the zoom factor with a step size from 0.5f to 6.0f?

current_zoom += (@in ? 0.5f : -0.5f);

Maybe it would be a good idea to make the maximum zoom factor and step size adjustable in Switchboard Display Plug?

@mmohsinkhan
Copy link
Author

mmohsinkhan commented Jul 19, 2020

Good to see you here, because of you I'm using EOS as my daily driver.

I made the simplest change possible to make it work on my system, changed 2.5f to 6.0f on line # 85 🥇

+1 for Switchboard Display Plug option.

@meisenzahl
Copy link
Member

Good to see you here, because of you I'm using EOS as my daily driver.

Because of me? What have I done? 😅️

@mmohsinkhan
Copy link
Author

Because of me? What have I done?

It was not possible for me to use EOS with out of the box magnification factor. Because of your answer on Reddit I was able to increase magnification factor.

@meisenzahl
Copy link
Member

I didn't answer your question at Reddit. Another user was faster 😁️

@mmohsinkhan
Copy link
Author

mmohsinkhan commented Jul 19, 2020

I didn't answer your question at Reddit. Another user was faster

Ohh. Hehe.
But still I must say thanks, you are marking required updates in source code here.

I was using Deepin before I switched to EOS. Only reason I started exploring other distro was because desktop magnification stopped working properly on their Deepin latest build v20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants