Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EditableItemList is not setting the value on Field #9228

Closed
turt2live opened this issue Mar 21, 2019 · 3 comments
Closed

EditableItemList is not setting the value on Field #9228

turt2live opened this issue Mar 21, 2019 · 3 comments
Labels
P2 T-Defect T-Task Tasks for the team like planning

Comments

@turt2live
Copy link
Member 

\..\src\rageshake\rageshake.js:61 Warning: Failed prop type: The prop `value` is marked as required in `Field`, but its value is `undefined`.
    in Field (created by EditableItemList)
    in EditableItemList (created by AliasSettings)
    in div (created by AliasSettings)
    in AliasSettings (created by GeneralRoomSettingsTab)
    in div (created by GeneralRoomSettingsTab)
    in div (created by GeneralRoomSettingsTab)
    in GeneralRoomSettingsTab (created by RoomSettingsDialog)
    in div (created by TabbedView)
    in div (created by TabbedView)
    in div (created by TabbedView)
    in TabbedView (created by RoomSettingsDialog)
    in div (created by RoomSettingsDialog)
    in div (created by FocusTrap)
    in FocusTrap (created by BaseDialog)
    in BaseDialog (created by RoomSettingsDialog)
    in RoomSettingsDialog (created by AsyncWrapper)
    in AsyncWrapper
    in div
    in div
@lampholder
Copy link
Member

@turt2live - do you want to triage this one?

@turt2live turt2live added T-Task Tasks for the team like planning P2 labels May 2, 2019
@turt2live
Copy link
Member Author

Done. We should probably fix it, but it doesn't seem to be hurting anything.

@t3chguy
Copy link
Member

t3chguy commented Aug 9, 2019 •
edited
Loading

Fixed by matrix-org/matrix-react-sdk@89ece26#diff-5ffc926d12421168d7166162f5c83872R126

@t3chguy t3chguy closed this as completed Aug 9, 2019
su-ex added a commit to SchildiChat/element-web that referenced this issue Sep 15, 2022
@su-ex
Merge tag 'v1.11.5' into sc
5c1a172 
* Device manager - hide unverified security recommendation when only current session is unverified ([\element-hq#9228](matrix-org/matrix-react-sdk#9228)). Contributed by @kerryarchibald.
* Device manager - scroll to filtered list from security recommendations ([\element-hq#9227](matrix-org/matrix-react-sdk#9227)). Contributed by @kerryarchibald.
* Device manager - updated dropdown style in filtered device list ([\element-hq#9226](matrix-org/matrix-react-sdk#9226)). Contributed by @kerryarchibald.
* Device manager - device type and verification icons on device tile ([\element-hq#9197](matrix-org/matrix-react-sdk#9197)). Contributed by @kerryarchibald.
* Description of DM room with more than two other people is now being displayed correctly ([\element-hq#9231](matrix-org/matrix-react-sdk#9231)). Fixes element-hq#23094.
* Fix voice messages with multiple composers ([\element-hq#9208](matrix-org/matrix-react-sdk#9208)). Fixes element-hq#23023. Contributed by @grimhilt.
* Fix suggested rooms going missing ([\element-hq#9236](matrix-org/matrix-react-sdk#9236)). Fixes element-hq#23190.
* Fix tooltip infinitely recursing ([\element-hq#9235](matrix-org/matrix-react-sdk#9235)). Fixes matrix-org/element-web-rageshakes#15107, matrix-org/element-web-rageshakes#15093 matrix-org/element-web-rageshakes#15092 and matrix-org/element-web-rageshakes#15077.
* Fix plain text export saving ([\element-hq#9230](matrix-org/matrix-react-sdk#9230)). Contributed by @jryans.
* Add missing space in SecurityRoomSettingsTab ([\element-hq#9222](matrix-org/matrix-react-sdk#9222)). Contributed by @gefgu.
* Make use of js-sdk roomNameGenerator to handle i18n for generated room names ([\element-hq#9209](matrix-org/matrix-react-sdk#9209)). Fixes element-hq#21369.
* Fix progress bar regression throughout the app ([\element-hq#9219](matrix-org/matrix-react-sdk#9219)). Fixes element-hq#23121.
* Reuse empty string & space string logic for event types in devtools ([\element-hq#9218](matrix-org/matrix-react-sdk#9218)). Fixes element-hq#23115.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 T-Defect T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turt2live @lampholder @t3chguy