"Suggested Rooms" list in a space does not appear since Element v1.11.2

[syldrathecat]

Steps to reproduce

1. Click on a space which contains un-joined, suggested rooms

Outcome

What did you expect?

In Element v1.11.1, a collapsible room list called "Suggested Rooms" is displayed in the side bar.

What happened instead?

In Element v1.11.2 or later, no "Suggested Rooms" list is displayed.

I believe I have narrowed down the commit that breaks this to matrix-org/matrix-react-sdk@c5e982f

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

1.11.4

Homeserver

No response

Will you send logs?

No

[syldrathecat]

I have identified the cause, here is a patch that fixes the issue:

diff --git a/src/components/views/rooms/RoomList.tsx b/src/components/views/rooms/RoomList.tsx
index b2493db25c..6698486054 100644
--- a/src/components/views/rooms/RoomList.tsx
+++ b/src/components/views/rooms/RoomList.tsx
@@ -596,8 +596,6 @@ export default class RoomList extends React.PureComponent<IProps, IState> {
 
                 if (this.state.feature_favourite_messages && orderedTagId === DefaultTagID.SavedItems) {
                     extraTiles = this.renderFavoriteMessagesList();
-                } else {
-                    extraTiles = null;
                 }
 
                 const aesthetics = TAG_AESTHETICS[orderedTagId];

[t3chguy]

@syldrathecat thanks for the issue & pointer, matrix-org/matrix-react-sdk#9236 fixes it