Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In login/register, riot freezes if you go to Advanced, remove the IS url and click next #10666

Closed
dbkr opened this issue Aug 27, 2019 · 3 comments
Closed

In login/register, riot freezes if you go to Advanced, remove the IS url and click next #10666

dbkr opened this issue Aug 27, 2019 · 3 comments
Assignees
@dbkr
Labels
A-Identity-Server Privacy T-Defect

Comments

@dbkr
Copy link
Member

dbkr commented Aug 27, 2019

No description provided.

@turt2live
Copy link
Member

https://github.com/matrix-org/riot-web-rageshakes/issues/1715

@dbkr dbkr changed the title riot freezes if you go to Advanced, remove the IS url and click next In login/register, riot freezes if you go to Advanced, remove the IS url and click next Aug 27, 2019
@dbkr dbkr self-assigned this Aug 27, 2019
dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 27, 2019
@dbkr
Don't infinite loop on server change
ac2b8b8 
ServerConfig assumed that the state was already correct when
checking the given urls against the default, but that is not
neccessarily the case (eg. the validation can return a different
url to what the user entered). This would cause an infinite loop
because it would keep firing onServerConfigChange to change to
the desired URLs but the state would never change.

Fixes part of element-hq/element-web#10666
@dbkr dbkr mentioned this issue Aug 27, 2019
Merged
@dbkr
Copy link
Member Author

dbkr commented Aug 28, 2019

Above PR fixed the infinite loop but it now just doesn't let you set no IS at all. Given the option to configure an IS at login/registration will go away altogether soon, I'm not sure it's really worth trying to make this do the right thing.

@jryans
Copy link
Collaborator

jryans commented Aug 28, 2019

Yes, I think we can consider that sufficiently fixed, given that removing the IS field (#10553) is due to land shortly.

@jryans jryans closed this as completed Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbkr dbkr

Labels
A-Identity-Server Privacy T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jryans @dbkr @turt2live