Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ability to set an IS at login/registration #10553

Closed
lampholder opened this issue Aug 14, 2019 · 5 comments · Fixed by matrix-org/matrix-react-sdk#3343
Closed

Remove the ability to set an IS at login/registration #10553

lampholder opened this issue Aug 14, 2019 · 5 comments · Fixed by matrix-org/matrix-react-sdk#3343
Assignees
@jryans
Labels
A-Identity-Server A-Login A-Registration Privacy T-Enhancement

Comments

@lampholder
Copy link
Member

No description provided.

@jryans jryans changed the title In case this isn't captured elsewhere, make sure we remove the ability to set an IS at login/registration Remove the ability to set an IS at login/registration Aug 15, 2019
This was referenced Aug 16, 2019
Closed
Closed
@jryans
Copy link
Collaborator

jryans commented Aug 19, 2019

There is a backwards compatibility issue here, as older HSes will still need an IS supplied for registration with email and password reset, but new HSes will not.

See also migration work generally in #10593.

@jryans jryans self-assigned this Aug 19, 2019
@jryans jryans removed their assignment Aug 19, 2019
@jryans
Copy link
Collaborator

jryans commented Aug 20, 2019

/versions from the HS describes whether an IS is already known to the HS. If an IS is known to the HS, the IS field can be hidden / removed (UX to be determined).

@jryans
Copy link
Collaborator

jryans commented Aug 20, 2019

@lampholder, do we need more product thinking around how we want the IS field to removed, or is the goal clear and we need designs?

@lampholder
Copy link
Member Author

I'm thinking:

  • user chooses to register or reset password
  • user chooses to enter custom server details
  • user is prompted to enter custom homeserver url
  • we check with that homeserver's /versions to see if an IS is needed for registration/password reset
  • if an identity server is needed, the form expands to solicit an identity server from the user, too
    • this transition should be animated

image

@jryans
Copy link
Collaborator

jryans commented Aug 22, 2019

Thanks @lampholder! It seems clear how to proceed now.

I also verified that we don't need the IS at login time, so we can always hide it during that flow.

@jryans jryans removed the X-Blocked label Aug 22, 2019
@jryans jryans self-assigned this Aug 22, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 23, 2019
@jryans
Reveal custom IS field only when required
72ec6c7 
This hides the identity server at first from the custom server auth flows. For
the flows that may need an IS if the HS requires it (registration, password
reset), we then check with the HS before proceeding further and reveal the IS
field if it is in fact needed.

Fixes element-hq/element-web#10553
@jryans jryans mentioned this issue Aug 23, 2019
Merged
This was referenced Aug 28, 2019
Merged
Closed
su-ex added a commit to SchildiChat/element-web that referenced this issue Apr 25, 2023
@su-ex
Merge tag 'v1.11.30' into sc
1968a49 
* Fixes for [CVE-2023-30609](https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=CVE-2023-30609) / GHSA-xv83-x443-7rmw
* Pick sensible default option for phone country dropdown ([\element-hq#10627](matrix-org/matrix-react-sdk#10627)). Fixes element-hq#3528.
* Relate field validation tooltip via aria-describedby ([\element-hq#10522](matrix-org/matrix-react-sdk#10522)). Fixes element-hq#24963.
* Handle more completion types in rte autocomplete ([\element-hq#10560](matrix-org/matrix-react-sdk#10560)). Contributed by @alunturner.
* Show a tile for an unloaded predecessor room if it has via_servers ([\element-hq#10483](matrix-org/matrix-react-sdk#10483)). Contributed by @andybalaam.
* Exclude message timestamps from aria live region ([\element-hq#10584](matrix-org/matrix-react-sdk#10584)). Fixes element-hq#5696.
* Make composer format bar an aria toolbar ([\element-hq#10583](matrix-org/matrix-react-sdk#10583)). Fixes element-hq#11283.
* Improve accessibility of font slider ([\element-hq#10473](matrix-org/matrix-react-sdk#10473)). Fixes element-hq#20168 and element-hq#24962.
* fix file size display from kB to KB ([\element-hq#10561](matrix-org/matrix-react-sdk#10561)). Fixes element-hq#24866. Contributed by @NSV1991.
* Handle /me in rte ([\element-hq#10558](matrix-org/matrix-react-sdk#10558)). Contributed by @alunturner.
* bind html with switch for manage extension setting option ([\element-hq#10553](matrix-org/matrix-react-sdk#10553)). Contributed by @NSV1991.
* Handle command completions in RTE ([\element-hq#10521](matrix-org/matrix-react-sdk#10521)). Contributed by @alunturner.
* Add room and user avatars to rte ([\element-hq#10497](matrix-org/matrix-react-sdk#10497)). Contributed by @alunturner.
* Support for MSC3882 revision 1 ([\element-hq#10443](matrix-org/matrix-react-sdk#10443)). Contributed by @hughns.
* Check profiles before starting a DM ([\element-hq#10472](matrix-org/matrix-react-sdk#10472)). Fixes element-hq#24830.
* Quick settings: Change the copy / labels on the options ([\element-hq#10427](matrix-org/matrix-react-sdk#10427)). Fixes element-hq#24522. Contributed by @justjanne.
* Update rte autocomplete styling ([\element-hq#10503](matrix-org/matrix-react-sdk#10503)). Contributed by @alunturner.
* Fix create subspace dialog not working ([\element-hq#10652](matrix-org/matrix-react-sdk#10652)). Fixes element-hq#24882
* Fix multiple accessibility defects identified by AXE ([\element-hq#10606](matrix-org/matrix-react-sdk#10606)).
* Fix view source from edit history dialog always showing latest event ([\element-hq#10626](matrix-org/matrix-react-sdk#10626)). Fixes element-hq#21859.
* element-hq#21451 Fix WebGL disabled error message ([\element-hq#10589](matrix-org/matrix-react-sdk#10589)). Contributed by @rashmitpankhania.
* Properly translate errors in `AddThreepid.ts` so they show up translated to the user but not in our logs ([\element-hq#10432](matrix-org/matrix-react-sdk#10432)). Contributed by @MadLittleMods.
* Fix overflow on auth pages ([\element-hq#10605](matrix-org/matrix-react-sdk#10605)). Fixes element-hq#19548.
* Fix incorrect avatar background colour when using a custom theme ([\#10598](matrix-org/matrix-react-sdk#10598)). Contributed by @jdauphant.
* Remove dependency on `org.matrix.e2e_cross_signing` unstable feature ([\element-hq#10593](matrix-org/matrix-react-sdk#10593)).
* Update setting description to match reality ([\element-hq#10600](matrix-org/matrix-react-sdk#10600)). Fixes element-hq#25106.
* Fix no identity server in help & about settings ([\element-hq#10563](matrix-org/matrix-react-sdk#10563)). Fixes element-hq#25077.
* Fix: Images no longer reserve their space in the timeline correctly ([\element-hq#10571](matrix-org/matrix-react-sdk#10571)). Fixes element-hq#25082. Contributed by @kerryarchibald.
* Fix issues with inhibited accessible focus outlines ([\element-hq#10579](matrix-org/matrix-react-sdk#10579)). Fixes element-hq#19742.
* Fix read receipts falling from sky ([\element-hq#10576](matrix-org/matrix-react-sdk#10576)). Fixes element-hq#25081.
* Fix avatar text issue in rte ([\element-hq#10559](matrix-org/matrix-react-sdk#10559)). Contributed by @alunturner.
* fix resizer only work with left mouse click ([\element-hq#10546](matrix-org/matrix-react-sdk#10546)). Contributed by @NSV1991.
* Fix send two join requests when joining a room from spotlight search ([\#10534](matrix-org/matrix-react-sdk#10534)). Fixes element-hq#25054.
* Highlight event when any version triggered a highlight ([\element-hq#10502](matrix-org/matrix-react-sdk#10502)). Fixes element-hq#24923 and element-hq#24970. Contributed by @kerryarchibald.
* Fix spacing of headings of integration manager on General settings tab ([\element-hq#10232](matrix-org/matrix-react-sdk#10232)). Fixes element-hq#24085. Contributed by @luixxiul.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Identity-Server A-Login A-Registration Privacy T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reveal custom IS field only when required matrix-org/matrix-react-sdk
2 participants
@jryans @lampholder