-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show speaker in the spotlight in large grids #2416
Show speaker in the spotlight in large grids #2416
Conversation
3244514
to
199cc83
Compare
199cc83
to
023e224
Compare
023e224
to
7ea5082
Compare
src/state/CallViewModel.ts
Outdated
@@ -504,7 +504,9 @@ export class CallViewModel extends ViewModel { | |||
(grid, spotlight, screenShares): Layout => ({ | |||
type: "grid", | |||
spotlight: | |||
screenShares.length > 0 ? spotlight : undefined, | |||
screenShares.length > 0 || grid.length > 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the 20 seems somewhat random. I think this should either become a config or needs a comment what made us decide to hard code this to 20.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe also a "needs to show scrollbars" is the better condition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be best to use a non hardcoded condition here.
If we use the 20 limit as a stop gap is also okay. But then I think it would be nice to have comments explaining and justifying it (maybe even mentioning that this could be done with a "do we need scrollbars" condition
7ea5082
to
e04affe
Compare
I think I do have an argument against basing the decision on whether there is a scroll bar:
However I totally get the desire to not use an arbitrary number. Basing the decision on whether there is a scroll bar would be pretty non-trivial, and this part of the designs is still subject to change (we want to workshop it further), so: I suggest that the scroll bar method is not worth the time investment at this stage, regardless of whether my argument above makes sense. |
I get behind this! But I like going with this first and making a decision that requires a lot of dev effort based on more usage experience! |
Based on #2382