Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New spotlight layout #2382

Merged
merged 9 commits into from
Jul 18, 2024
Merged

New spotlight layout #2382

merged 9 commits into from
Jul 18, 2024

Conversation

robintown
Copy link
Member

@robintown robintown commented May 17, 2024 •
edited
Loading

Based on #2381

Closes #2219
Closes #1215

@fkwp fkwp marked this pull request as ready for review May 19, 2024 13:23
@fkwp fkwp requested a review from a team as a code owner May 19, 2024 13:23
@robintown
Copy link
Member Author

Not yet quite ready to review yet. I think I'd like to add some more comments before I consider this ready.

@robintown robintown marked this pull request as draft May 20, 2024 14:05
@robintown robintown force-pushed the spotlight-layout branch 2 times, most recently from 86e52cd to a727cf9 Compare June 7, 2024 14:37
@robintown robintown marked this pull request as ready for review June 7, 2024 14:38
@robintown robintown changed the base branch from livekit to new-call-layouts June 7, 2024 14:49
@robintown robintown mentioned this pull request Jun 7, 2024
Merged
toger5
toger5 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fairly quick review.
This looks good and I could not find something that is an obvious problem.

src/grid/Grid.tsx Show resolved Hide resolved
src/tile/SpotlightTile.tsx Show resolved Hide resolved
src/grid/GridLayout.tsx Show resolved Hide resolved
src/state/CallViewModel.ts Outdated Show resolved Hide resolved
@robintown robintown merged commit 24870de into element-hq:new-call-layouts Jul 18, 2024
3 checks passed
This was referenced Jul 19, 2024
Closed
Closed
Closed
Closed
@hanthor
Copy link

hanthor commented Jul 19, 2024

I think I just tested this out on cell.element.dev. It doesn't seems to be giving the spotlight position to unmuted, talking participants. This is what I did:

  1. start the call from my laptop at call.element.dev
  2. send the invite link to myself
  3. join on 2 different android phones
  4. mute on all devices
  5. my computer's video is in the spotlight and has had it the whole time
  6. unmute and start talking on my phone
  7. the spotlight does not change, but the other participant get highlighted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toger5 toger5 toger5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robintown @hanthor @toger5