[ftr] implement FtrService classes and migrate common services #99546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
implement/ftr-service-class
branch
from
0baa557
to
5e6872a
Compare
spalger
force-pushed
the
implement/ftr-service-class
branch
from
b839d33
to
e5e4236
Compare
|
@elasticmachine merge upstream |
This was referenced May 24, 2021
💚 Build Succeeded
Metrics [docs]Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
spalger
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
This was referenced May 24, 2021
jbudz
approved these changes
May 25, 2021
spalger
added
the
auto-backport
💔 Backport failed
To backport manually run: |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 25, 2021
…ic#99546) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # test/common/services/deployment.ts # test/common/services/index.ts # test/common/services/saved_object_info.ts # test/functional/apps/visualize/index.ts
spalger
pushed a commit
that referenced
this pull request
May 25, 2021
… (#100585) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # test/common/services/deployment.ts # test/common/services/index.ts # test/common/services/saved_object_info.ts # test/functional/apps/visualize/index.ts
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 26, 2021
…deprecation-ilm-policy * 'master' of github.com:elastic/kibana: (101 commits) [ftr] migrate "docTable" service to FtrService class (elastic#100595) [ftr] migrate "listingTable" service to FtrService class (elastic#100606) Fixed comparing real value with formatted according to mode. (elastic#100456) [ftr] migrate "dataGrid" service to FtrService class (elastic#100593) [ftr] migrate "fieldEditor" to FtrService class (elastic#100597) [ftr] migrate "filterBar" service to FtrService class (elastic#100601) [triggersActionsUi] Reduce page load bundle to under 100kB (elastic#97770) [build] Clean jest configs (elastic#100594) refact(NA): remove extra pkg_npm target and add specific target folders for @kbn/analytics on Bazel (elastic#100569) Update dependency @elastic/charts to v29.2.0 (elastic#100587) [Maps] convert LayerPanel to typescript (elastic#100481) [Upgrade Assistant] Address copy feedback (elastic#99632) Open/Closed filter for observability alerts page (elastic#99217) One liner to expose the EQL query for debugging for users (elastic#100565) [KibanaPageLayout] Solution Nav specific styles & props (elastic#100089) [ftr] implement FtrService classes and migrate common services (elastic#99546) [XY] [Lens] Adds opacity slider (elastic#100453) [Reporting] ILM policy for managing reporting indices (elastic#100130) [Reporting] ILM policy for managing reporting indices (elastic#100130) [DOCS] Remove redundant maps attribute (elastic#100426) ... # Conflicts: # x-pack/plugins/reporting/server/lib/store/report_ilm_policy.ts # x-pack/plugins/reporting/server/lib/store/store.test.ts # x-pack/plugins/reporting/server/lib/store/store.ts
ecezalp
pushed a commit
to ecezalp/kibana
that referenced
this pull request
May 26, 2021
…ic#99546) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ecezalp
pushed a commit
to ecezalp/kibana
that referenced
this pull request
May 26, 2021
…ic#99546) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #99148
In order to migrate the root
testproject to a TS project using references (which is required for other work) we need to stop using class expressions within provider functions and instead export classes that are instantiated by the test runner. To do this I've added support for such classes to theProviderCollectionclass used by the FTR and started the migration by converting thetest/common/services, including:retryrandomnessdeployment: converted from POJOsavedObjectInfo: converted from POJOsecurity: service is async so it needed to use a provider function (FtrServicecan't be asynchronously initialized) but was also using class expressions.The other services don't use class expressions or POJO return values, so they didn't need to be migrated and were left untouched.
Reviewer tip: many of the changes were just white-space, so you should consider hiding whitespace changes.