Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ftr] migrate dashboard services to FtrService class #100519

Merged

Conversation

spalger
Copy link
Contributor

@spalger spalger commented May 24, 2021

In order to migrate the root test directory to its own TypeScript project that can be ref'd we need to stop returning class expressions from provider functions. Part of #99148

Migrates the test/services/dashboard classes to the new FtrService class, basically just extracted the classes from the provider and remapped services/PageObjects referenced in scope to access private properties on the service instance. Viewing changes with whitespace disabled will help with review.

@spalger spalger force-pushed the migrate/ftr-service-class/dashboard-services branch from 80d30f0 to 70ebf69 Compare May 25, 2021 18:55
@spalger spalger added release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.14.0 v8.0.0 labels May 25, 2021
@spalger spalger marked this pull request as ready for review May 25, 2021 20:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@spalger spalger requested a review from cqliu1 May 25, 2021 20:51
@spalger spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label May 25, 2021
@spalger spalger enabled auto-merge (squash) May 25, 2021 20:58
Copy link
Contributor

@cqliu1 cqliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward. Approved! 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 386 342 -44
stackAlerts 101 95 -6
total -342

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit e682b55 into elastic:master May 26, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 100519

@spalger spalger deleted the migrate/ftr-service-class/dashboard-services branch May 26, 2021 18:51
spalger pushed a commit to spalger/kibana that referenced this pull request May 26, 2021
Co-authored-by: spalger <spalger@users.noreply.github.com>
# Conflicts:
#	test/functional/services/dashboard/add_panel.ts
#	test/functional/services/index.ts
spalger pushed a commit that referenced this pull request May 26, 2021
Co-authored-by: spalger <spalger@users.noreply.github.com>
# Conflicts:
#	test/functional/services/dashboard/add_panel.ts
#	test/functional/services/index.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants