[ML] Adds functional tests for anomaly detection job custom URLs (#10…

…0455) * [ML] Adds functional tests for anomaly detection job custom URLs * [ML] Remove debug test tag from custom URL tests * [ML] Update custom URL editor Jest snapshots * [ML] Clean up in embeddables tests to fix dashboard test * [ML] Delete test dashboard after test suites complete * [ML] Edits to custom URL tests following review Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
elastic · May 26, 2021 · f77ff2d · f77ff2d
1 parent c5f8aee
commit f77ff2d
Show file tree

Hide file tree

Showing 19 changed files with 622 additions and 16 deletions.
diff --git a/...l/public/application/jobs/components/custom_url_editor/__snapshots__/editor.test.tsx.snap b/...l/public/application/jobs/components/custom_url_editor/__snapshots__/editor.test.tsx.snap
diff --git a/.../ml/public/application/jobs/components/custom_url_editor/__snapshots__/list.test.tsx.snap b/.../ml/public/application/jobs/components/custom_url_editor/__snapshots__/list.test.tsx.snap
diff --git a/x-pack/plugins/ml/public/application/jobs/components/custom_url_editor/editor.tsx b/x-pack/plugins/ml/public/application/jobs/components/custom_url_editor/editor.tsx
@@ -209,7 +209,7 @@ export const CustomUrlEditor: FC<CustomUrlEditorProps> = ({
         </h4>
       </EuiTitle>
       <EuiSpacer size="m" />
-      <EuiForm className="ml-edit-url-form">
+      <EuiForm className="ml-edit-url-form" data-test-subj="mlJobCustomUrlForm">
         <EuiFormRow
           label={
             <FormattedMessage id="xpack.ml.customUrlsEditor.labelLabel" defaultMessage="Label" />
@@ -239,6 +239,7 @@ export const CustomUrlEditor: FC<CustomUrlEditorProps> = ({
             idSelected={type}
             onChange={onTypeChange}
             className="url-link-to-radio"
+            data-test-subj="mlJobCustomUrlLinkToTypeInput"
           />
         </EuiFormRow>
 
@@ -256,6 +257,7 @@ export const CustomUrlEditor: FC<CustomUrlEditorProps> = ({
               options={dashboardOptions}
               value={kibanaSettings.dashboardId}
               onChange={onDashboardChange}
+              data-test-subj="mlJobCustomUrlDashboardNameInput"
               compressed
             />
           </EuiFormRow>
@@ -275,6 +277,7 @@ export const CustomUrlEditor: FC<CustomUrlEditorProps> = ({
               options={indexPatternOptions}
               value={kibanaSettings.discoverIndexPatternId}
               onChange={onDiscoverIndexPatternChange}
+              data-test-subj="mlJobCustomUrlDiscoverIndexPatternInput"
               compressed
             />
           </EuiFormRow>
@@ -298,6 +301,7 @@ export const CustomUrlEditor: FC<CustomUrlEditorProps> = ({
                 selectedOptions={selectedEntityOptions}
                 onChange={onQueryEntitiesChange}
                 isClearable={true}
+                data-test-subj="mlJobCustomUrlQueryEntitiesInput"
               />
             </EuiFormRow>
           )}
@@ -321,6 +325,7 @@ export const CustomUrlEditor: FC<CustomUrlEditorProps> = ({
                     options={timeRangeOptions}
                     value={timeRange.type}
                     onChange={onTimeRangeTypeChange}
+                    data-test-subj="mlJobCustomUrlTimeRangeInput"
                     compressed
                   />
                 </EuiFormRow>
@@ -343,6 +348,7 @@ export const CustomUrlEditor: FC<CustomUrlEditorProps> = ({
                       value={timeRange.interval}
                       onChange={onTimeRangeIntervalChange}
                       isInvalid={isInvalidTimeRange}
+                      data-test-subj="mlJobCustomUrlTimeRangeIntervalInput"
                       compressed
                     />
                   </EuiFormRow>
@@ -365,6 +371,7 @@ export const CustomUrlEditor: FC<CustomUrlEditorProps> = ({
               rows={2}
               value={otherUrlSettings.urlValue}
               onChange={onOtherUrlValueChange}
+              data-test-subj="mlJobCustomUrlOtherTypeUrlInput"
               compressed
             />
           </EuiFormRow>

diff --git a/x-pack/plugins/ml/public/application/jobs/components/custom_url_editor/list.tsx b/x-pack/plugins/ml/public/application/jobs/components/custom_url_editor/list.tsx
@@ -160,6 +160,7 @@ export const CustomUrlList: FC<CustomUrlListProps> = ({ job, customUrls, setCust
             }
             isInvalid={isInvalidLabel}
             error={invalidLabelError}
+            data-test-subj="mlJobEditCustomUrlItemLabel"
           >
             <EuiFieldText
               value={label}
@@ -239,6 +240,7 @@ export const CustomUrlList: FC<CustomUrlListProps> = ({ job, customUrls, setCust
                 aria-label={i18n.translate('xpack.ml.customUrlEditorList.testCustomUrlAriaLabel', {
                   defaultMessage: 'Test custom URL',
                 })}
+                data-test-subj="mlJobEditTestCustomUrlButton"
               />
             </EuiToolTip>
           </EuiFormRow>
@@ -264,6 +266,7 @@ export const CustomUrlList: FC<CustomUrlListProps> = ({ job, customUrls, setCust
                     defaultMessage: 'Delete custom URL',
                   }
                 )}
+                data-test-subj={`mlJobEditDeleteCustomUrlButton_${index}`}
               />
             </EuiToolTip>
           </EuiFormRow>