Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixes styling of Single Metric Viewer chart for dark theme #93581

Merged
merged 3 commits into from
Mar 9, 2021
Merged

[ML] Fixes styling of Single Metric Viewer chart for dark theme #93581

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3bede5
[ML] Fizes styling of Simgle Metric Viewer chart for dark theme
peteharverson Mar 4, 2021
2e30e5c
[ML] Fix lint error in scss
peteharverson Mar 4, 2021
fb5de9b
Merge branch 'master' into ml-smv-dark-styling-fixes
kibanamachine Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions x-pack/plugins/ml/public/application/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ $mlColorCritical: #FE5050;
$mlColorMajor: #FBA740;
$mlColorMinor: #FDEC25;
$mlColorWarning: #8BC8FB;
$mlColorLowWarning: #D2E9F7;
$mlColorUnknown: #C0C0C0;

$mlColorCriticalText: makeHighContrastColor($mlColorCritical, $euiColorEmptyShade);
Expand Down
65 changes: 12 additions & 53 deletions x-pack/plugins/ml/public/application/timeseriesexplorer/_timeseriesexplorer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,6 @@
.ml-time-series-explorer {
color: $euiColorDarkShade;

.no-results-container {
text-align: center;
font-size: $euiFontSizeL;
padding-top: 60px; // SASSTODO: variabalize

.no-results {
background-color: $euiFocusBackgroundColor;
padding: $euiSize;
border-radius: $euiBorderRadius;
display: inline-block;

i {
color: $euiColorPrimary;
margin-right: $euiSizeXS;
}

div:nth-child(2) {
margin-top: $euiSizeS;
font-size: $euiFontSizeXS;
}
}
}

.results-container {
.panel-title {
font-size: $euiFontSizeM;
Expand Down Expand Up @@ -65,7 +42,7 @@
}

.axis .tick line {
stroke: rgba(0, 0, 0, .1);
stroke: $euiColorLightShade;
}

.chart-border {
Expand All @@ -89,46 +66,41 @@
}

.area.bounds {
fill: rgba(50, 167, 194, .25); // Needs variable
fill: transparentize($euiColorPrimary, .8);
pointer-events: none;
}

.values-line {
fill: none;
stroke: #32A7C2; // Needs variable
stroke: $euiColorPrimary;
stroke-width: 2;
pointer-events: none;
}

.values-line.forecast {
stroke: #CCA300; // Needs variable
stroke: $euiColorVis5;
pointer-events: none;
}

.values-dots circle {
fill: #32A7C2; // Needs variable
stroke-width: 0;
}

.hidden {
visibility: hidden;
}

.area.forecast {
fill: rgba(204, 163, 0, .25); // Needs variable
fill: transparentize($euiColorVis5, .7);
pointer-events: none;
}

.metric-value {
opacity: 1;
fill: transparent;
stroke: #32A7C2;
stroke: $euiColorPrimary;
stroke-width: 0;
}

.anomaly-marker {
stroke-width: 1px;
stroke: #AAAAAA; // Needs variable
stroke: $euiColorMediumShade;
}

.anomaly-marker.critical {
Expand All @@ -148,15 +120,15 @@
}

.anomaly-marker.low {
fill: #D2E9F7; // Needs variable
fill: $mlColorLowWarning;
}

.metric-value:hover,
.anomaly-marker:hover,
.anomaly-marker.highlighted {
stroke-width: 6px;
stroke-opacity: .65;
stroke: #32A7C2;
stroke: $euiColorPrimary;
}

rect.scheduled-event-marker {
Expand All @@ -169,7 +141,7 @@
.forecast {
.metric-value,
.metric-value:hover {
stroke: #CCA300;
stroke: $euiColorVis5;
}
}

Expand Down Expand Up @@ -214,35 +186,22 @@
fill: $euiTextColor;
}

.area.context {
fill: rgba(50, 167, 194, .25); // Needs variable
}

.values-line {
stroke-width: 1;
}

.area.context.forecast {
fill: rgba(204, 163, 0, .25); // Needs variable
}

.mask {
polygon {
fill-opacity: .1;
}

.area.bounds {
fill: #D6D6D6;
fill: $euiColorLightShade;
}

.values-line {
stroke-width: 1;
stroke: #B8B8B8;
}

.values-dots circle {
fill: #B8B8B8;
stroke-width: 0;
stroke: $euiColorMediumShade;
}
}
}
Expand Down
6 changes: 1 addition & 5 deletions .../ml/public/application/timeseriesexplorer/components/timeseries_chart/timeseries_chart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,11 +1076,7 @@ class TimeseriesChartIntl extends Component {
.defined((d) => d.lower !== null && d.upper !== null);

if (modelPlotEnabled === true) {
cxtGroup
.append('path')
.datum(data)
.attr('class', 'area context')
.attr('d', contextBoundsArea);
cxtGroup.append('path').datum(data).attr('class', 'area bounds').attr('d', contextBoundsArea);
}

const contextValuesLine = d3.svg
Expand Down