-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Fixes styling of Single Metric Viewer chart for dark theme #93581
[ML] Fixes styling of Single Metric Viewer chart for dark theme #93581
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
⏳ Build in-progress, with failures
Failed CI StepsTo update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡
Out of curiosity, should |
@MichaelMarcialis here is how it looks with Compared to On balance I prefer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/management/_runtime_fields·js.management runtime fields create runtime field should create runtime fieldStandard Out
Stack Trace
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
…tic#93581) * [ML] Fizes styling of Simgle Metric Viewer chart for dark theme * [ML] Fix lint error in scss Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…) (#94074) * [ML] Fizes styling of Simgle Metric Viewer chart for dark theme * [ML] Fix lint error in scss Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Fixes issues with the styling of the chart in the Single Metric Viewer when using dark theme.
Also switches the color used for the line and model bounds to the
euiColorPrimary
shade of blue, consistent with the charts used in the job wizard, and switches out all remaining uses in the_timeseriesexplorer.scss
of hardcoded colors to EUI color variables.Before:
After:
After:
Part of #30368
Checklist