Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] waterfall improve legend spacing #92158

Merged
merged 3 commits into from
Feb 24, 2021

Conversation

shahzad31
Copy link
Contributor

Summary

Fixes: #90033

Improve spacing and layout for waterfall legend items

image

image

image

@shahzad31 shahzad31 requested a review from a team as a code owner February 22, 2021 12:43
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Feb 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 self-assigned this Feb 22, 2021
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 v8.0.0 labels Feb 22, 2021
@paulb-elastic
Copy link
Contributor

The legend only seems to be fixed in the footer properly when displaying 2 rows. If the screen isn't wide enough and requires 3 rows, there is a second scroll bar to see the rest of the legend:
image

@paulb-elastic
Copy link
Contributor

Actually, is that becuase of #91941

@shahzad31
Copy link
Contributor Author

The legend only seems to be fixed in the footer properly when displaying 2 rows. If the screen isn't wide enough and requires 3 rows, there is a second scroll bar to see the rest of the legend:
image

Yes @paulb-elastic double scroll will be fixed with other PR. Once that is merged. This will work fine as well.

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the scroll changes.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 938.9KB 939.2KB +276.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@shahzad31 shahzad31 merged commit 8957ed8 into elastic:master Feb 24, 2021
@shahzad31 shahzad31 deleted the legend-readability branch February 24, 2021 18:28
@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 24, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 24, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 24, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.12 / #92691
7.x / #92692

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Feb 24, 2021
Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 24, 2021
Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Synthetic waterfall UI] legend is hard to read
5 participants