Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] fix double scroll on legend height change #92155

Merged
merged 4 commits into from
Feb 23, 2021
Merged

[Uptime] fix double scroll on legend height change #92155

merged 4 commits into from
Feb 23, 2021

Conversation

shahzad31
Copy link
Contributor

Summary

Fixes: #91941

Use legend ref to determine legend height instead of hard coded value

image

@shahzad31 shahzad31 requested a review from a team as a code owner February 22, 2021 12:23
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Feb 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 labels Feb 22, 2021
@shahzad31 shahzad31 added auto-backport Deprecated - use backport:version if exact versions are needed v8.0.0 labels Feb 23, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
uptime 594 600 +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 928.5KB 932.7KB +4.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dominiqueclarke
dominiqueclarke approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit 7593a91 into elastic:master Feb 23, 2021
@shahzad31 shahzad31 deleted the waterfall-double-scroll branch February 23, 2021 13:38
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 23, 2021
@shahzad31 @kibanamachine
[Uptime] fix double scroll on legend height change (elastic#92155)
1aa35ca
@kibanamachine kibanamachine mentioned this pull request Feb 23, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 23, 2021
@shahzad31 @kibanamachine
[Uptime] fix double scroll on legend height change (elastic#92155)
4f75aae
@kibanamachine kibanamachine mentioned this pull request Feb 23, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.12 / #92405
✅ 7.x / #92406

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Feb 23, 2021
@kibanamachine @shahzad31
[Uptime] fix double scroll on legend height change (#92155) (#92405)
380b311 
Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 23, 2021
@kibanamachine @shahzad31
[Uptime] fix double scroll on legend height change (#92155) (#92406)
90f6376 
Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Uptime] Waterfall Chart has a slight double scroll
4 participants
@shahzad31 @elasticmachine @kibanamachine @dominiqueclarke