Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests - stabilize reporting API network policy test for cloud #88456

Merged

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Jan 15, 2021

Summary

This PR fixes a reporting API network policy test failure that occurred during cloud execution.

Details

This is a similar change to #83787, the tl;dr is:

  • The Rx.interval(100).pipe sends requests in a 100ms interval but if the request takes longer than this (which happens on cloud), the result is not fetched correctly but a new request is sent. So ultimately, the operation times out, although the request has already been successful.
  • The functional retry service fires the request until it is successful or the timeout is reached no matter how long one single request takes (unless it's longer than the timeout, in which case the operation will fail as expected), so should be more stable in a slow environment. Running the test on my cloud cluster passed with that change.

Closes #84989

@pheyos pheyos added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes test-api-integration v7.11.0 v7.12.0 labels Jan 15, 2021
@pheyos pheyos requested a review from tsullivan January 15, 2021 13:00
@pheyos pheyos self-assigned this Jan 15, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pheyos pheyos merged commit b362736 into elastic:master Jan 15, 2021
@pheyos pheyos deleted the stabilize_reporting_network_policy_test_in_cloud branch January 15, 2021 16:58
pheyos added a commit to pheyos/kibana that referenced this pull request Jan 15, 2021
…oud (elastic#88456)

This PR fixes a reporting API network policy test failure that occurred during cloud execution.
pheyos added a commit to pheyos/kibana that referenced this pull request Jan 15, 2021
…oud (elastic#88456)

This PR fixes a reporting API network policy test failure that occurred during cloud execution.
pheyos added a commit that referenced this pull request Jan 16, 2021
…oud (#88456) (#88488)

This PR fixes a reporting API network policy test failure that occurred during cloud execution.
kibanamachine pushed a commit to dominiqueclarke/kibana that referenced this pull request Jan 18, 2021
…oud (elastic#88456) (elastic#88489)

This PR fixes a reporting API network policy test failure that occurred during cloud execution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants