Functional tests - stabilize reporting API network policy test for cloud #88456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheyos
added
v8.0.0
release_note:skip
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Jan 15, 2021
…oud (elastic#88456) This PR fixes a reporting API network policy test failure that occurred during cloud execution.
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Jan 15, 2021
…oud (elastic#88456) This PR fixes a reporting API network policy test failure that occurred during cloud execution.
kibanamachine
pushed a commit
to dominiqueclarke/kibana
that referenced
this pull request
Jan 18, 2021
…oud (elastic#88456) (elastic#88489) This PR fixes a reporting API network policy test failure that occurred during cloud execution.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a reporting API network policy test failure that occurred during cloud execution.
Details
This is a similar change to #83787, the tl;dr is:
Rx.interval(100).pipesends requests in a 100ms interval but if the request takes longer than this (which happens on cloud), the result is not fetched correctly but a new request is sent. So ultimately, the operation times out, although the request has already been successful.retryservice fires the request until it is successful or the timeout is reached no matter how long one single request takes (unless it's longer than the timeout, in which case the operation will fail as expected), so should be more stable in a slow environment. Running the test on my cloud cluster passed with that change.Closes #84989