-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional tests - stabilize reporting tests for cloud execution #83787
Functional tests - stabilize reporting tests for cloud execution #83787
Conversation
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the description, will be curious to see how that retry handler deals with 409
s
|
||
const reportsDeleted = await deleted$.toPromise(); | ||
expect(reportsDeleted).to.be(true); | ||
await retry.tryForTime(5000, async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious to see how this handles the 409's we return sometimes. I'm not super familiar with how retry.tryForTime
works internally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .expect(200)
will throw an error for any response code different than 200
and this will be caught by the retry, that will then execute the code block again (until the timeout is reached).
…stic#83787) This PR fixes some reporting API test failure that occurred during cloud execution.
…stic#83787) This PR fixes some reporting API test failure that occurred during cloud execution.
) (#83883) This PR fixes some reporting API test failure that occurred during cloud execution.
) (#83884) This PR fixes some reporting API test failure that occurred during cloud execution.
* master: (38 commits) [ML] Data frame analytics: Adds functionality to map view (elastic#83710) Add usage collection for savedObject tagging (elastic#83160) [SECURITY_SOLUTION] 145: Advanced Policy Tests (elastic#82898) [APM] Service overview transactions table (elastic#83429) [ML] Fix Single Metric Viewer not loading if job is metric with no partition (elastic#83880) do not export types from 3rd party modules as 'type' (elastic#83803) [Fleet] Allow to send SETTINGS action (elastic#83707) Fixes Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details·ts - Actions and Triggers app Alert Details Alert Instances renders the active alert instances (elastic#83478) [Uptime]Reduce chart height on monitor detail page (elastic#83777) [APM] Prefer `APIReturnType` over `PromiseReturnType` (elastic#83843) [Observability] Fix telemetry for Observability Overview (elastic#83847) [Alerting] Adds generic UI for the definition of conditions for Action Groups (elastic#83278) ensure workload agg doesnt run until next interval when it fails (elastic#83632) [ILM] Policy form should not throw away data (elastic#83077) [Monitoring] Stop collecting Kibana Usage in bulkUploader (elastic#83546) [TSVB] fix wrong imports (elastic#83798) [APM] Correlations UI POC (elastic#82256) list all the refs in tsconfig.json (elastic#83678) Bump jest (and related packages) to v26.6.3 (elastic#83724) Functional tests - stabilize reporting tests for cloud execution (elastic#83787) ...
Summary
This PR fixes some reporting API test failure that occurred during cloud execution.
Details
Retry in
deleteAllReports
Rx.interval
value is an option that I considered but response times can significantly vary depending on the cloud region and on the location of the test runner. That's why I think it makes sense to fire the request until it is successful or the timeout is reached no matter how long one single request takes (unless it's longer than the timeout, in which case the operation will fail as expected).toPromise
will be removed in a future version.Closes #78065
Closes #78066
Closes #78067
Closes #78068
Closes #80266
Closes #80267
Closes #80269
Closes #80270
Closes #80271
Sorting in merge user state for docvalue_fields
expect(resText).to.eql(fixtures.CSV_RESULT_DOCVALUE);
with the following output:order_by
is exactly the same in all of the documents.order_id
as a secondary sort field gave me consistent results in cloud and on my local machine.Closes #80268