Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Handle errors happenning during Fleet setup in the UI #87185

Merged
merged 2 commits into from
Jan 4, 2021
Merged

[Fleet] Handle errors happenning during Fleet setup in the UI #87185

merged 2 commits into from
Jan 4, 2021

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jan 4, 2021

Summary

Related to #86864

Currently when an error happens during fleet agents setup the UI is stuck loading

This PR handle the error and display it as we do for the plugin setup

Screen Shot 2021-01-04 at 1 31 52 PM

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v7.12.0 labels Jan 4, 2021
@nchaulet nchaulet self-assigned this Jan 4, 2021
@nchaulet nchaulet requested a review from a team January 4, 2021 17:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@nchaulet nchaulet added the release_note:skip Skip the PR/issue when compiling release notes label Jan 4, 2021
@EricDavisX
Copy link
Contributor

@nchaulet Thanks so much for volunteering the improvement when errors arise - my 2 cents, I don't think it warrants a port-back to 7.11 at this point. Unless you or @ph want?

jen-huang
jen-huang approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small copy suggestion. Otherwise LGTM

As it's a low-risk fix, I'm in favor of backporting this to 7.11.

x-pack/plugins/fleet/public/applications/fleet/sections/agents/index.tsx Outdated Show resolved Hide resolved
@nchaulet @jen-huang
Update x-pack/plugins/fleet/public/applications/fleet/sections/agents…
db7e438 
…/index.tsx

Co-authored-by: Jen Huang <its.jenetic@gmail.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 967.4KB 967.8KB +469.0B

Distributable file count

id before after diff
default 47264 48024 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nchaulet nchaulet merged commit a0f330c into elastic:master Jan 4, 2021
@nchaulet nchaulet deleted the feature-fix-fleet-setup-error-handling branch January 4, 2021 23:02
@nchaulet nchaulet mentioned this pull request Jan 4, 2021
Merged
nchaulet added a commit to nchaulet/kibana that referenced this pull request Jan 4, 2021
@nchaulet
[Fleet] Handle errors happenning during Fleet setup in the UI (elasti…
f4c81b6 
…c#87185)
@nchaulet nchaulet mentioned this pull request Jan 4, 2021
Merged
nchaulet added a commit to nchaulet/kibana that referenced this pull request Jan 4, 2021
@nchaulet
[Fleet] Handle errors happenning during Fleet setup in the UI (elasti…
132afe1 
…c#87185)
nchaulet added a commit that referenced this pull request Jan 5, 2021
@nchaulet
[Fleet] Handle errors happenning during Fleet setup in the UI (#87185) (
01e5d30 
#87257)
nchaulet added a commit that referenced this pull request Jan 5, 2021
@nchaulet
[Fleet] Handle errors happenning during Fleet setup in the UI (#87185) (
7877aaf 
#87256)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jen-huang jen-huang jen-huang approved these changes

Assignees

@nchaulet nchaulet

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nchaulet @elasticmachine @EricDavisX @kibanamachine @jen-huang