[Time to Visualize] Fix Dashboard OnAppLeave #86193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etermine whether or not to show onAppLeave confirm
ThomThomson
added
Feature:Dashboard
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
force-pushed
the
fix/dashboardConfirmOnAppLeave
branch
2 times, most recently
from
725f147
to
cc3aded
Compare
ThomThomson
force-pushed
the
fix/dashboardConfirmOnAppLeave
branch
from
cc3aded
to
85f2d43
Compare
streamich
approved these changes
Dec 18, 2020
…ConfirmOnAppLeave
crob611
approved these changes
Dec 18, 2020
poffdeluxe
approved these changes
Dec 18, 2020
|
@crob611, This is a good point. I think the only way that could happen is if the transfer was cancelled, but there isn't yet code in place to cancel the state transfer once it's started. If we add any confirm modals or anything for the redirect, we will have to be aware of this. |
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Dec 18, 2020
Added isTransferInProgress to embeddable_state_transfer for apps to determine whether or not to show onAppLeave confirm
ThomThomson
added a commit
that referenced
this pull request
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A small fix that adds shows a confirm modal on leaving the dashboard application with unsaved changes.
This warning will not show when the user is redirecting to an editor via the create new button or via the edit link on a dashboard panel. This is accomplished with a new property in the
embeddableStateTransferservice, used to determine whether or not a transfer is in progress.Note Ignore the blue header, it's just a browser script to help tell kibana instances apart.
Checklist
Delete any items that are not applicable to this PR.
For maintainers