Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Time to Visualize] Dashboard Warn on App Leave #81360

Closed
ThomThomson opened this issue Oct 21, 2020 · 2 comments
Closed

[Time to Visualize] Dashboard Warn on App Leave #81360

ThomThomson opened this issue Oct 21, 2020 · 2 comments
Labels
Feature:Dashboard Dashboard related features Project:TimeToVisualize Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

Describe the feature:
Now that dashboard can store panels with unsaved state (by value panels), it is important to warn the user on app leave when they may lose unsaved changes. This can be done through the on app leave handler, but we will have to track and diff panel states from one save to the next in order to ensure the warning shows when it should.
@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Project:TimeToVisualize labels Oct 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@ThomThomson ThomThomson mentioned this issue Oct 21, 2020
Closed
4 tasks
@ThomThomson ThomThomson mentioned this issue Dec 15, 2020
Closed
@ThomThomson
Copy link
Contributor Author

Closed by #86193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Dashboard Dashboard related features Project:TimeToVisualize Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ThomThomson @elasticmachine