Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [Vega] Filter bar in Vega is not usable with non default index pattern. (#84090) #84607

Merged
merged 1 commit into from
Dec 1, 2020
Merged

[7.x] [Vega] Filter bar in Vega is not usable with non default index pattern. (#84090) #84607

merged 1 commit into from
Dec 1, 2020
+290 −110

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Dec 1, 2020

Backports the following commits to 7.x:

@alexwizp @kibanamachine
[Vega] Filter bar in Vega is not usable with non default index patter…
4713fd0 
…n. (elastic#84090)

* [Vega] Filtering is not working

Closes: elastic#81738

* fix CI

* some work

* some work

* add tests for extract_index_pattern

* simplify extract_index_pattern

* fix type error

* cleanup

* Update vega_base_view.js

* Update extract_index_pattern.test.ts

* fix PR comments

* fix some comments

* findByTitle -> getByTitle

* remove getByTitle

* fix vega_base_view

* fix jest

* allow to set multiple indexes from top_nav

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeVega 92 93 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeVega 1.5MB 1.5MB +1.4KB
visualize 126.7KB 128.0KB +1.3KB
total +2.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 976.9KB 976.8KB -99.0B
visTypeTimeseries 138.0KB 137.7KB -370.0B
visTypeVega 57.7KB 60.5KB +2.8KB
total +2.4KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit bb6c259 into elastic:7.x Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexwizp @kibanamachine