[Vega] Filter bar in Vega is not usable with non default index pattern. #84090

alexwizp · 2020-11-23T14:33:53Z

Closes: #81738, Closes: #62122, Closes: #56833, Closes: #19408

Summary

Describe the bug: Filter bar in Vega is not usable with non default index pattern.

Steps to reproduce:

Create a dashboard with only vega viz ( non default index pattern should be used)
Click on add filter

Expected behavior:
The fields should be filled with values from the index pattern used in Vega visualization.

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

Closes: elastic#81738

elasticmachine · 2020-11-25T14:21:31Z

Pinging @elastic/kibana-app (Team:KibanaApp)

alexwizp · 2020-11-25T18:09:49Z

@elasticmachine merge upstream

src/plugins/vis_type_vega/public/lib/extract_index_pattern.test.ts

src/plugins/vis_type_vega/public/vega_view/vega_base_view.js

alexwizp · 2020-11-27T10:36:10Z

src/plugins/visualize/public/application/components/visualize_top_nav.tsx

+    const asyncSetIndexPattern = async () => {
+      let index: IndexPattern | null = null;
+
+      if (vis.type.getUsedIndexPattern) {


@ppisljar maybe we should rethink that comment #82964 (comment) and move getUsedIndexPattern into vis.ts? Now we know that we need that code at least from 2 different places.

It also seems to me not entirely correct to use such hooks and set the default index pattern in this place.I think that instead of undefined vis.ts should return the default index for vis.data.indexPattern

ppisljar · 2020-11-30T06:51:09Z

@mattkime can you please take a look at this one ?

alexwizp · 2020-11-30T09:58:43Z

@elasticmachine merge upstream

alexwizp · 2020-11-30T13:16:07Z

@elasticmachine merge upstream

mattkime · 2020-11-30T17:07:57Z

src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts

+   * @returns {Promise<SavedObject|undefined>}
+   */
+  findByTitle = async (title: string, refresh: boolean = false) => {
+    if (!this.savedObjectsCache || refresh) {


I think this could rely on getIdsWithTitle, filter based on the result, and then get

Lets call this getByTitle

# Conflicts: # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.indexpatternsservice.md # src/plugins/data/public/public.api.md

kibanamachine · 2020-12-01T09:06:50Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b538cab

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`visTypeVega`	92	93	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`visTypeVega`	1.5MB	1.5MB	+1.4KB
`visualize`	126.3KB	127.6KB	+1.3KB
total			+2.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	974.3KB	974.2KB	-99.0B
`visTypeTimeseries`	137.9KB	137.5KB	-370.0B
`visTypeVega`	57.7KB	60.5KB	+2.8KB
total			+2.4KB

History

💚 Build #90861 succeeded 7a0a9b7
💔 Build #90835 failed cea9694
💔 Build #90830 failed d8022ef
💚 Build #90807 succeeded 5c9643a
💔 Build #90824 failed cea4317

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…n. (elastic#84090) * [Vega] Filtering is not working Closes: elastic#81738 * fix CI * some work * some work * add tests for extract_index_pattern * simplify extract_index_pattern * fix type error * cleanup * Update vega_base_view.js * Update extract_index_pattern.test.ts * fix PR comments * fix some comments * findByTitle -> getByTitle * remove getByTitle * fix vega_base_view * fix jest * allow to set multiple indexes from top_nav Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…n. (#84090) (#84607) * [Vega] Filtering is not working Closes: #81738 * fix CI * some work * some work * add tests for extract_index_pattern * simplify extract_index_pattern * fix type error * cleanup * Update vega_base_view.js * Update extract_index_pattern.test.ts * fix PR comments * fix some comments * findByTitle -> getByTitle * remove getByTitle * fix vega_base_view * fix jest * allow to set multiple indexes from top_nav Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…n. (elastic#84090) * [Vega] Filtering is not working Closes: elastic#81738 * fix CI * some work * some work * add tests for extract_index_pattern * simplify extract_index_pattern * fix type error * cleanup * Update vega_base_view.js * Update extract_index_pattern.test.ts * fix PR comments * fix some comments * findByTitle -> getByTitle * remove getByTitle * fix vega_base_view * fix jest * allow to set multiple indexes from top_nav Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # src/plugins/vis_type_vega/public/vega_type.ts # src/plugins/vis_type_vega/public/vega_visualization.test.js # src/plugins/vis_type_vega/public/vega_visualization.ts

…n. (#84090) (#86476) * [Vega] Filtering is not working Closes: #81738 * fix CI * some work * some work * add tests for extract_index_pattern * simplify extract_index_pattern * fix type error * cleanup * Update vega_base_view.js * Update extract_index_pattern.test.ts * fix PR comments * fix some comments * findByTitle -> getByTitle * remove getByTitle * fix vega_base_view * fix jest * allow to set multiple indexes from top_nav Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # src/plugins/vis_type_vega/public/vega_type.ts # src/plugins/vis_type_vega/public/vega_visualization.test.js # src/plugins/vis_type_vega/public/vega_visualization.ts Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

alexwizp added 5 commits November 23, 2020 17:33

[Vega] Filtering is not working

a16fec4

Closes: elastic#81738

Merge remote-tracking branch 'upstream/master' into 81738

39dd4b7

fix CI

9cf57e7

some work

6952981

Merge remote-tracking branch 'upstream/master' into 81738

58a1d93

alexwizp force-pushed the 81738 branch from 248a76d to 58a1d93 Compare November 24, 2020 15:05

alexwizp added 5 commits November 24, 2020 18:53

some work

d0c3f53

add tests for extract_index_pattern

ef4e702

Merge remote-tracking branch 'upstream/master' into 81738

410cc4c

simplify extract_index_pattern

e66c610

Merge remote-tracking branch 'upstream/master' into 81738

7fd0ad2

alexwizp force-pushed the 81738 branch from 3145655 to 7fd0ad2 Compare November 24, 2020 17:10

fix type error

0eb9680

alexwizp requested review from stratoula and sulemanof November 25, 2020 10:37

cleanup

e068c90

alexwizp self-assigned this Nov 25, 2020

alexwizp added v7.11.0 v8.0.0 Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:fix labels Nov 25, 2020

alexwizp marked this pull request as ready for review November 25, 2020 14:21

alexwizp requested a review from a team November 25, 2020 14:21

alexwizp requested a review from a team as a code owner November 25, 2020 14:21

Merge branch 'master' into 81738

6c846f0

stratoula reviewed Nov 26, 2020

View reviewed changes

src/plugins/vis_type_vega/public/lib/extract_index_pattern.test.ts Outdated Show resolved Hide resolved

stratoula reviewed Nov 26, 2020

View reviewed changes

src/plugins/vis_type_vega/public/vega_view/vega_base_view.js Outdated Show resolved Hide resolved

kibanamachine and others added 2 commits November 27, 2020 03:35

Merge branch 'master' into 81738

7b25522

fix some comments

37044aa

alexwizp force-pushed the 81738 branch from f2ca98a to 37044aa Compare November 27, 2020 10:32

alexwizp commented Nov 27, 2020

View reviewed changes

Merge branch 'master' into 81738

4cfe514

Merge branch 'master' into 81738

90c87c0

mattkime requested changes Nov 30, 2020

View reviewed changes

alexwizp added 3 commits November 30, 2020 20:30

findByTitle -> getByTitle

1548365

Merge remote-tracking branch 'upstream/master' into 81738

5c9643a

# Conflicts: # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.indexpatternsservice.md # src/plugins/data/public/public.api.md

remove getByTitle

d8022ef

alexwizp force-pushed the 81738 branch from cea4317 to d8022ef Compare November 30, 2020 18:29

fix vega_base_view

cea9694

alexwizp requested a review from mattkime November 30, 2020 18:35

mattkime approved these changes Nov 30, 2020

View reviewed changes

alexwizp added 2 commits November 30, 2020 22:46

fix jest

7a0a9b7

allow to set multiple indexes from top_nav

b538cab

alexwizp merged commit d4c02bb into elastic:master Dec 1, 2020

alexwizp mentioned this pull request Dec 1, 2020

[7.x] [Vega] Filter bar in Vega is not usable with non default index pattern. (#84090) #84607

Merged

alexwizp mentioned this pull request Dec 18, 2020

TSVB doesn't communicate it's index-patterns to dashboard #82964

Merged

8 tasks

alexwizp mentioned this pull request Dec 18, 2020

[7.10] [Vega] Filter bar in Vega is not usable with non default index pattern. (#84090) #86476

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Vega] Filter bar in Vega is not usable with non default index pattern. #84090

[Vega] Filter bar in Vega is not usable with non default index pattern. #84090

alexwizp commented Nov 23, 2020 •

edited

Loading

elasticmachine commented Nov 25, 2020

alexwizp commented Nov 25, 2020

alexwizp Nov 27, 2020 •

edited

Loading

ppisljar commented Nov 30, 2020

alexwizp commented Nov 30, 2020

alexwizp commented Nov 30, 2020

mattkime Nov 30, 2020

kibanamachine commented Dec 1, 2020

[Vega] Filter bar in Vega is not usable with non default index pattern. #84090

[Vega] Filter bar in Vega is not usable with non default index pattern. #84090

Conversation

alexwizp commented Nov 23, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Nov 25, 2020

alexwizp commented Nov 25, 2020

alexwizp Nov 27, 2020 • edited Loading

Choose a reason for hiding this comment

ppisljar commented Nov 30, 2020

alexwizp commented Nov 30, 2020

alexwizp commented Nov 30, 2020

mattkime Nov 30, 2020

Choose a reason for hiding this comment

kibanamachine commented Dec 1, 2020

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

alexwizp commented Nov 23, 2020 •

edited

Loading

alexwizp Nov 27, 2020 •

edited

Loading