Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix bug in terms formatting #82776

Merged
merged 1 commit into from
Nov 6, 2020
Merged

[Lens] Fix bug in terms formatting #82776

merged 1 commit into from
Nov 6, 2020

Conversation

wylieconlon
Copy link
Contributor

The Terms aggregation was not maintaining the link between its field and its dataType, which is important to get support for numeric formatting without formatting non-numeric fields.

Steps to validate:

  1. Create an initial XY chart
  2. Drag a numeric field onto the horizontal axis, which will create an Intervals aggregation
  3. Switch the horizontal axis to Top Values
  4. Choose a number formatter, anything but Default
  5. Switch the field to any non-numeric field, and the number format will be removed and you will see correct data

Fixes #82771

Checklist

@wylieconlon wylieconlon requested review from dej611, flash1293, mbondyra and a team November 5, 2020 19:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
lens 1.0MB 1.0MB +174.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

flash1293
flash1293 approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected, LGTM. Thanks for this fix!

mbondyra
mbondyra approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on FF.

@wylieconlon wylieconlon merged commit 03ee1a6 into elastic:master Nov 6, 2020
@wylieconlon wylieconlon deleted the lens/fix-terms-formatting branch November 6, 2020 14:54
This was referenced Nov 6, 2020
Merged
Merged
wylieconlon pushed a commit to wylieconlon/kibana that referenced this pull request Nov 6, 2020
@wylieconlon
[Lens] Fix bug in terms formatting (elastic#82776)
5558070
wylieconlon pushed a commit to wylieconlon/kibana that referenced this pull request Nov 6, 2020
@wylieconlon
[Lens] Fix bug in terms formatting (elastic#82776)
b5025bf
wylieconlon pushed a commit that referenced this pull request Nov 6, 2020
[Lens] Fix bug in terms formatting (#82776) (#82842)
7552c17
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 10, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

wylieconlon pushed a commit that referenced this pull request Nov 12, 2020
@kibanamachine
[Lens] Fix bug in terms formatting (#82776) (#82843)
e316601 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@mbondyra mbondyra mbondyra approved these changes

@dej611 dej611 Awaiting requested review from dej611

Assignees
No one assigned
Labels
Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.1 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Terms aggregation keeps the numeric formatter for non-numeric data
5 participants
@wylieconlon @elasticmachine @kibanamachine @flash1293 @mbondyra