[Security Solution] Fix Overview cypress tests (#82761)

elastic · Nov 5, 2020 · 9bff56d · 9bff56d
1 parent 250fe67
commit 9bff56d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/x-pack/plugins/security_solution/cypress/integration/overview.spec.ts b/x-pack/plugins/security_solution/cypress/integration/overview.spec.ts
@@ -13,7 +13,7 @@ import { OVERVIEW_URL } from '../urls/navigation';
 
 describe('Overview Page', () => {
   it('Host stats render with correct values', () => {
-    cy.stubSearchStrategyApi('overviewHostQuery', 'overview_search_strategy');
+    cy.stubSearchStrategyApi('overview_search_strategy');
     loginAndWaitForPage(OVERVIEW_URL);
     expandHostStats();
 
@@ -23,7 +23,7 @@ describe('Overview Page', () => {
   });
 
   it('Network stats render with correct values', () => {
-    cy.stubSearchStrategyApi('overviewNetworkQuery', 'overview_search_strategy');
+    cy.stubSearchStrategyApi('overview_search_strategy');
     loginAndWaitForPage(OVERVIEW_URL);
     expandNetworkStats();
 

diff --git a/x-pack/plugins/security_solution/cypress/support/commands.js b/x-pack/plugins/security_solution/cypress/support/commands.js
@@ -40,7 +40,6 @@ Cypress.Commands.add('stubSecurityApi', function (dataFileName) {
 });
 
 Cypress.Commands.add('stubSearchStrategyApi', function (
-  queryId,
   dataFileName,
   searchStrategyName = 'securitySolutionSearchStrategy'
 ) {
@@ -49,7 +48,7 @@ Cypress.Commands.add('stubSearchStrategyApi', function (
   });
   cy.server();
   cy.fixture(dataFileName).as(`${dataFileName}JSON`);
-  cy.route('POST', `internal/search/${searchStrategyName}/${queryId}`, `@${dataFileName}JSON`);
+  cy.route('POST', `internal/search/${searchStrategyName}`, `@${dataFileName}JSON`);
 });
 
 Cypress.Commands.add(

diff --git a/x-pack/plugins/security_solution/cypress/support/index.d.ts b/x-pack/plugins/security_solution/cypress/support/index.d.ts
@@ -8,11 +8,7 @@ declare namespace Cypress {
   interface Chainable<Subject> {
     promisify(): Promise<Subject>;
     stubSecurityApi(dataFileName: string): Chainable<Subject>;
-    stubSearchStrategyApi(
-      queryId: string,
-      dataFileName: string,
-      searchStrategyName?: string
-    ): Chainable<Subject>;
+    stubSearchStrategyApi(dataFileName: string, searchStrategyName?: string): Chainable<Subject>;
     attachFile(fileName: string, fileType?: string): Chainable<JQuery>;
     waitUntil(
       fn: (subject: Subject) => boolean | Chainable<boolean>,