Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APM Experiments settings #81554

Merged
merged 3 commits into from
Oct 28, 2020
Merged

APM Experiments settings #81554

merged 3 commits into from
Oct 28, 2020

Conversation

smith
Copy link
Contributor

@smith smith commented Oct 23, 2020 •
edited
Loading

  • Register advanced settings in server startup that show in the Kibana advanced settings UI. (Fixes [APM] Experiments settings #81396.)
  • Format settings pages to be more consistent.

image

@smith
Add advanced settings for APM
5e032f8 
* Register advanced settings in server startup that show in the Kibana advanced settings UI. (Fixes elastic#81396.)
* Format settings pages to be more consistent.
@smith smith marked this pull request as ready for review October 27, 2020 15:03
@smith smith requested a review from a team as a code owner October 27, 2020 15:03
ogupte
ogupte reviewed Oct 27, 2020
View reviewed changes
x-pack/plugins/apm/public/components/app/ServiceDetails/ServiceDetailTabs.tsx

const overviewTab = {
link: (
<a title="UNDER CONSTRUCTION" href="#">
Copy link
Contributor

@ogupte ogupte Oct 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is UNDER CONSTRUCTION intentional because it's an experiment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's just a placeholder and behind the flag and will be replaced in #81718.

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

ogupte
ogupte reviewed Oct 27, 2020
View reviewed changes
x-pack/plugins/apm/public/components/app/ServiceDetails/ServiceDetailTabs.tsx

if (uiSettings.get(enableServiceOverview)) {
tabs.unshift(overviewTab);
}
Copy link
Contributor

@ogupte ogupte Oct 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're initializing tabs here anyways we can avoid an array mutation:

const tabs = uiSettings.get(enableServiceOverview) ? 
    [overviewTab, transactionsTab, errorsTab, serviceMapTab] : 
    [transactionsTab, errorsTab, serviceMapTab];

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the mutation since we're pushing on to the array later anyway and I thought is was clearer.

@smith smith requested a review from ogupte October 27, 2020 20:29
ogupte
ogupte approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@smith
Copy link
Contributor Author

smith commented Oct 27, 2020

retest

@smith
Copy link
Contributor Author

smith commented Oct 28, 2020

@elasticmachine merge upstream

@smith
Copy link
Contributor Author

smith commented Oct 28, 2020

retest

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
apm 1272 1273 +1

async chunks size

id before after diff
apm 3.3MB 3.3MB +958.0B

distributable file count

id before after diff
default 48109 48111 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 333f873 into elastic:master Oct 28, 2020
@smith smith deleted the nls/experiments branch October 28, 2020 15:38
smith added a commit to smith/kibana that referenced this pull request Oct 28, 2020
@smith
APM Experiments settings (elastic#81554)
ad10532 
* Add advanced settings for APM

* Register advanced settings in server startup that show in the Kibana advanced settings UI. (Fixes elastic#81396.)
* Format settings pages to be more consistent.
@smith smith mentioned this pull request Oct 28, 2020
Merged
smith added a commit that referenced this pull request Oct 28, 2020
@smith
APM Experiments settings (#81554) (#81913)
d934d7b 
* Register advanced settings in server startup that show in the Kibana advanced settings UI. (Fixes #81396.)
* Format settings pages to be more consistent.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 29, 2020
@gmmorris
Merge branch 'alerts/convert-to-tm-intervals' of github.com:gmmorris/…
93ba119 
…kibana into alerts/convert-to-tm-intervals

* 'alerts/convert-to-tm-intervals' of github.com:gmmorris/kibana: (88 commits)
  fixed jest
  APM Experiments settings (elastic#81554)
  [Resolver] Enable resolver test plugin tests (elastic#81339)
  Add TS project references for inspector  (elastic#81792)
  Add uri decode to es_ui_shared and fix navigation issues with special characters (elastic#80835)
  [Fleet] Rename ingestManager translations fleet (elastic#81837)
  [Logs UI] Transmit and render array field values in log entries (elastic#81385)
  Audit Logging: use the original url (elastic#81282)
  [User experience] Fix JS error rate (elastic#81512)
  [UX] Add median/percentile info in titles (elastic#79824)
  Support export for SO with circular refs (elastic#81582)
  Get rid of  global types (elastic#81739)
  [APM] Fix precommit script (elastic#81594)
  skips overview tests (elastic#81877)
  [Security Solution][Case] Fix connector's labeling (elastic#81824)
  Added simple test, which only covers successful case when edit happened right after task was complete previous execution
  [Maps] Fix EMS test (elastic#81856)
  [Security Solutions][Detections] - Fix bug, last response not showing for disabled rules (elastic#81783)
  skip flaky suite (elastic#81853)
  Fixed type checks and unit tests
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogupte ogupte ogupte approved these changes

Assignees
No one assigned
Labels
release_note:enhancement Team:APM All issues that need APM UI Team support v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Experiments settings
4 participants
@smith @elasticmachine @kibanamachine @ogupte